Closed Bug 1586433 Opened 5 years ago Closed 5 years ago

Crash in [@ js::XDRDecoder::~XDRDecoder]

Categories

(Core :: JavaScript Engine, defect, P1)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 --- fixed

People

(Reporter: marcia, Assigned: iain)

References

Details

(Keywords: crash, regression)

Crash Data

This bug is for crash report bp-8e7f153b-2fe1-40a5-a2e6-a66b30191004.

Seen while looking at nightly crash stats: https://bit.ly/2AHteMK. Crashes started in 20191003214801.

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c9c63f8447027d14ec2c541e82aae1014f08f812&tochange=2e1bfb7458de41a36432671c405eee62d897a761.

Bug 1584820 landed in that timeframe.

Top 10 frames of crashing thread:

0 xul.dll void js::XDRDecoder::~XDRDecoder js/src/vm/Xdr.h:449
1 xul.dll JS::DecodeScript js/src/jsapi.cpp:5886
2 xul.dll nsJSUtils::ExecutionContext::Decode dom/base/nsJSUtils.cpp:293
3 xul.dll nsresult mozilla::dom::ScriptLoader::EvaluateScript dom/script/ScriptLoader.cpp:2783
4 xul.dll nsresult mozilla::dom::ScriptLoader::ProcessRequest dom/script/ScriptLoader.cpp:2315
5 xul.dll mozilla::dom::ScriptLoader::ProcessPendingRequests dom/script/ScriptLoader.cpp:3125
6 xul.dll nsresult mozilla::dom::ScriptLoader::OnStreamComplete dom/script/ScriptLoader.cpp:3320
7 xul.dll nsresult mozilla::dom::ScriptLoadHandler::OnStreamComplete dom/script/ScriptLoadHandler.cpp:424
8 xul.dll nsresult nsIncrementalStreamLoader::OnStopRequest netwerk/base/nsIncrementalStreamLoader.cpp:85
9 xul.dll void mozilla::net::HttpChannelChild::DoOnStopRequest netwerk/protocol/http/HttpChannelChild.cpp:1258

Flags: needinfo?(iireland)

This whole set of patches has been backed out for now (see bug 1584820). The crash dumps have some interesting data, but we need to investigate further.

Crash Signature: [@ js::XDRDecoder::~XDRDecoder] → [@ js::XDRDecoder::~XDRDecoder] [@ <name omitted> | nsJSUtils::ExecutionContext::Decode ]
Flags: needinfo?(iireland)
Priority: -- → P1

As far as I can tell these crashes are gone.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → iireland
Target Milestone: --- → mozilla71

Hello,

Is this issue verifiable manually?
If so, could you please provide QA with STR to verify it?

Thank you in advance!

Flags: needinfo?(mozillamarcia.knous)

(In reply to Vlad Lucaci, QA (:vlucaci) from comment #4)

Hello,

Is this issue verifiable manually?
If so, could you please provide QA with STR to verify it?

Thank you in advance!

I don't believe so. Based on the fact that the crashes are no longer present in crash stats, I believe we are fine here.

Flags: needinfo?(mozillamarcia.knous)
You need to log in before you can comment on or make changes to this bug.