Closed
Bug 1586555
Opened 5 years ago
Closed 5 years ago
Tab bar is broken when using a high contrast theme with double buffering and D3D Compositor
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla71
People
(Reporter: sotaro, Assigned: sotaro)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
Created by Bug 1570879 Comment 17.
From investigation, the followings are necessary to address the problem.
- Clear parent window by transparent black.
- Use SwapChain with DXGI_ALPHA_MODE_PREMULTIPLIED for child window in GPU process.
SwapChain with DXGI_ALPHA_MODE_PREMULTIPLIED could cause performance regression. Then we need to use it only when necessary. When SwapChain switches between DXGI_ALPHA_MODE_IGNORE and DXGI_ALPHA_MODE_PREMULTIPLIED, the SwapChain needs to be re-created. In "Direct3D 11 (Advanced Layers)" or "CompositorD3D11" cases, it seems better just to disabled double buffering(DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL usage).
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
status-firefox69:
--- → unaffected
status-firefox70:
--- → unaffected
status-firefox71:
--- → affected
|
||
Comment 1•5 years ago
|
||
Sotaro: Is this something you're working on?
Flags: needinfo?(sotaro.ikeda.g)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Yes :)
Assignee: nobody → sotaro.ikeda.g
Flags: needinfo?(sotaro.ikeda.g)
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Keywords: regression
|
|
Assignee | |
Comment 4•5 years ago
|
||
:bas, can you review the patch(Attachment 9099439 [details])?
Flags: needinfo?(bas)
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(bas)
| Comment hidden (obsolete) |
|
||
Updated•5 years ago
|
Attachment #9100333 -
Attachment is obsolete: true
Pushed by sikeda.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1edd0bc8d83 Disable double buffering with D3D compositor when Glass is used r=bas
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
|
||
Updated•5 years ago
|
status-firefox67:
--- → unaffected
status-firefox68:
--- → unaffected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
|
|
||
Updated•5 years ago
|
|
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•