network ID: drop routes/addresses when link/address is removed by the kernel
Categories
(Core :: Networking, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | verified |
People
(Reporter: michal, Assigned: michal)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
When address or link is removed kernel does not necessarily notify via netlink that associated routes, addresses and neighbors are removed too.
Assignee | ||
Comment 1•5 years ago
|
||
Kernel can drop routes, addresses and neighbors without notification via netlink. So we update information in our structures as follows:
- when a link is removed all associated routes, addresses and neighbors are removed too
- when a link is disabled all associated routes and neighbors are removed
- when an address on a link is removed all routes and neighbors from this network are removed
All routes, neighbors and addresses always belong to some link, so a new class LinkInfo was created and it holds all information related to a single link. This makes finding information related to a specific link much easier.
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Backed out for perma fails on nsAutoPtr.h.
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=270277750&resultStatus=testfailed%2Cbusted%2Cexception&revision=fbc6bf62b19d6b48e1e31aec86e631fb04c9c8a3
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270277750&repo=autoland&lineNumber=1412
Backout: https://hg.mozilla.org/integration/autoland/rev/e95f4eb6c7e6826d158184372612d2e72a3cadfd
Assignee | ||
Comment 4•5 years ago
|
||
auto type wasn't a good choice, because nsAutoPtr<...> is used and the object is released after first iteration.
Comment 6•5 years ago
|
||
bugherder |
Hi, verified as fixed with device Google Pixel 3a XL, on Fenix/Firefox Preview Nightly 191021 (Build 12940607) with GeckoView 71.0a1-20191018095340.
Scenarios verified:
- Wi-Fi is connected and afterwards a disconnection of the network connection is made, followed by a refresh of the page.
- Mobile data is connected and afterwards a disconnection of the network connection is made, followed by a refresh of the page.
- Reconnecting both networks and see that all columns display the correct information.
I will change the the status from fixed to verified for status-firefox71
Description
•