Closed Bug 1586731 Opened 5 years ago Closed 5 years ago

network ID: drop routes/addresses when link/address is removed by the kernel

Categories

(Core :: Networking, defect, P1)

Unspecified
Linux
defect

Tracking

()

VERIFIED FIXED
mozilla71
Tracking Status
firefox71 --- verified

People

(Reporter: michal, Assigned: michal)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

When address or link is removed kernel does not necessarily notify via netlink that associated routes, addresses and neighbors are removed too.

Kernel can drop routes, addresses and neighbors without notification via netlink. So we update information in our structures as follows:

  • when a link is removed all associated routes, addresses and neighbors are removed too
  • when a link is disabled all associated routes and neighbors are removed
  • when an address on a link is removed all routes and neighbors from this network are removed

All routes, neighbors and addresses always belong to some link, so a new class LinkInfo was created and it holds all information related to a single link. This makes finding information related to a specific link much easier.

Attachment #9099243 - Attachment description: Bug 1586731 - network ID: drop routes/addresses when link/address is removed by the kernel, r?valentin → Bug 1586731 - network ID: drop routes/addresses when link/address is removed by the kernel, r=valentin
Pushed by mnovotny@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fbc6bf62b19d network ID: drop routes/addresses when link/address is removed by the kernel, r=valentin

auto type wasn't a good choice, because nsAutoPtr<...> is used and the object is released after first iteration.

Flags: needinfo?(michal.novotny)
Pushed by mnovotny@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c55fda1d64f network ID: drop routes/addresses when link/address is removed by the kernel, r=valentin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Hi, verified as fixed with device Google Pixel 3a XL, on Fenix/Firefox Preview Nightly 191021 (Build 12940607) with GeckoView 71.0a1-20191018095340.
Scenarios verified:

  • Wi-Fi is connected and afterwards a disconnection of the network connection is made, followed by a refresh of the page.
  • Mobile data is connected and afterwards a disconnection of the network connection is made, followed by a refresh of the page.
  • Reconnecting both networks and see that all columns display the correct information.
    I will change the the status from fixed to verified for status-firefox71
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: