Closed Bug 1586841 Opened 5 years ago Closed 5 years ago

Port ShieldFrameChild.jsm to JSWindowActors

Categories

(Shield :: General, task)

Product:
Shield
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Fission Milestone:M4, firefox72 fixed)

Status:
RESOLVED FIXED
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mconley, Assigned: jahnsjam)

References

Details

Attachments

(1 file)

Bug 1586841 - Port ShieldFrameChild.jsm to JSWindowActors.
(deleted), text/x-phabricator-request
Details

about:studies never loads in an oop-iframe, but the gunk it uses to communicate with the parent process is still using the message manager.

We should port it to use JSWindowActors.

The relevant child actor is here: https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/toolkit/components/normandy/content/ShieldFrameChild.jsm

Registration is here: https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/browser/components/BrowserGlue.jsm#328-336

Assignee: nobody → jahnsjam
Attachment #9100313 - Attachment description: Bug 1586841 - Port ShieldFrameChild.jsm to JSWindowActors. These are the actors that handle messaging on the about:shield page. → Bug 1586841 - Port ShieldFrameChild.jsm to JSWindowActors. These are the actors that handle messaging on the about:studies page.
Attachment #9100313 - Attachment description: Bug 1586841 - Port ShieldFrameChild.jsm to JSWindowActors. These are the actors that handle messaging on the about:studies page. → Bug 1586841 - Port ShieldFrameChild.jsm to JSWindowActors.
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/42a2ce72610b Port ShieldFrameChild.jsm to JSWindowActors. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/42a2ce72610b

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Regressions: 1593637

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: