Closed Bug 1586911 Opened 5 years ago Closed 5 years ago

Fix nsSHEntry::AddChild assertion after local->remote->local process switch in parser-created iframe

Categories

(Core :: DOM: Navigation, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When we have a parser-created iframe which starts out in-process, transitions to remote, and then transitions back to in-process, we create separate DocShells for the first and last in-process loads. Since both are network-created, and have the same child index, they both try to add themselves as children to their parent's SHistory at the same index. And since the entry for the first DocShell already exists at that index when we try to add the second, that triggers an assertion.

This isn't really ideal, but it is expected given the current state of session history under Fission. It should hopefully be solved more gracefully when the Fission-aware session history rewrite is done, but in the mean time, I think we should just ignore the conflict, since it's expected.

When we have a parser-created iframe which starts out in-process, transitions
to remote, and then transitions back to in-process, we create separate
DocShells for the first and last in-process loads. Since both are
network-created, and have the same child index, they both try to add
themselves as children to their parent's SHistory at the same index. And since
the entry for the first DocShell already exists at that index when we try to
add the second, that triggers an assertion.

This isn't really ideal, but it is expected given the current state of session
history under Fission. It should hopefully be solved more gracefully when the
Fission-aware session history rewrite is done, but in the mean time, I think
we should just ignore the conflict, since it's expected.

Status: NEW → ASSIGNED
Fission Milestone: --- → M4
Priority: -- → P2
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c0029f42afd2 Silence SHEntry assertion after local->remote->local iframe navigation. r=peterv
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: