Closed
Bug 1587741
Opened 5 years ago
Closed 5 years ago
Captive Portal Service should use a new detector when we start again
Categories
(Core :: Networking, defect, P2)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
If the captive portal service is disabled then enabled again when in a captive portal, we sometimes don't send the captive-portal-login observer notification because we're reusing the same mCaptiveDetector object, which believes it's already sent it.
We should use do_CreateInstance instead of do_GetService for this.
I have a testcase that triggers this in test_trr.js in bug 1552176, but I haven't managed to reduce it yet.
|
Assignee | |
Comment 1•5 years ago
|
||
If the captive portal service is disabled then enabled again when in a captive
portal, we sometimes don't send the captive-portal-login observer notification
because we're reusing the same mCaptiveDetector object, which believes it's
already sent it.
We should use do_CreateInstance instead of do_GetService for this.
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b085b41c10ce
Captive Portal Service should use a new detector when we start again r=mayhemer
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•