Open Bug 1587814 Opened 5 years ago Updated 2 years ago

Massive memory leaks when running Puppeteer unit tests

Categories

(Remote Protocol :: Agent, defect, P3)

defect

Tracking

(Not tracked)

REOPENED

People

(Reporter: whimboo, Unassigned)

References

Details

Attachments

(1 file)

Attached file Leak report (deleted) —

Running the puppeteer unit tests results in a lot of leaks. See the list of components from the attached log.

There will be several dependent bugs before we will have all this fixed.

Depends on: 1585272

This is actually a problem with Puppeteer itself. For each test a new instance of the Page domain is created, which also means Network.enable is called. There is no destructor code which would call Network.disable, and it means that all registered events and observer notifications from the Network domain are leaked.

I filed https://github.com/GoogleChrome/puppeteer/issues/5043 for that.

It also means that we cannot do much about it yet, and have to wait until it has been fixed in Puppeteer.

No longer depends on: 1585272

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:whimboo, maybe it's time to close this bug?

Flags: needinfo?(hskupin)

I checked again with a local debug build. Nothing obvious is visible anymore. Maybe the move to Typescript somewhat fixed it?

As such I'm going to close this bug.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(hskupin)
Resolution: --- → WORKSFORME

Err, running the mach command locally doesn't seem to fail when there are leaks. As such I didn't notice them.

Lots of them are still present so I'll reopen the bug, and handle it as a non-meta for now.

Keywords: meta
Summary: [meta] Massive memory leaks when running Puppeteer unit tests → Massive memory leaks when running Puppeteer unit tests
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Severity: normal normal → S3 S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: