Massive memory leaks when running Puppeteer unit tests
Categories
(Remote Protocol :: Agent, defect, P3)
Tracking
(Not tracked)
People
(Reporter: whimboo, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
text/plain
|
Details |
Running the puppeteer unit tests results in a lot of leaks. See the list of components from the attached log.
There will be several dependent bugs before we will have all this fixed.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
This is actually a problem with Puppeteer itself. For each test a new instance of the Page domain is created, which also means Network.enable
is called. There is no destructor code which would call Network.disable
, and it means that all registered events and observer notifications from the Network
domain are leaked.
I filed https://github.com/GoogleChrome/puppeteer/issues/5043 for that.
It also means that we cannot do much about it yet, and have to wait until it has been fixed in Puppeteer.
Comment 2•4 years ago
|
||
The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:whimboo, maybe it's time to close this bug?
Reporter | ||
Comment 3•4 years ago
|
||
I checked again with a local debug build. Nothing obvious is visible anymore. Maybe the move to Typescript somewhat fixed it?
As such I'm going to close this bug.
Reporter | ||
Comment 4•4 years ago
|
||
Err, running the mach command locally doesn't seem to fail when there are leaks. As such I didn't notice them.
Lots of them are still present so I'll reopen the bug, and handle it as a non-meta for now.
Reporter | ||
Updated•4 years ago
|
Updated•2 years ago
|
Description
•