Closed
Bug 1587931
Opened 5 years ago
Closed 5 years ago
LSNG: Force kill database actors during shutdown
Categories
(Core :: Storage: localStorage & sessionStorage, task, P1)
Core
Storage: localStorage & sessionStorage
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | unaffected |
| firefox70 | --- | fixed |
| firefox71 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Crash Data
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is an attempt to fix remaining LSNG shutdown hangs.
|
Assignee | |
Comment 1•5 years ago
|
||
Database actors are force killed after 5 seconds if the child side doesn't
respond to the RequestAllowToClose message during shutdown.
|
|
Assignee | |
Updated•5 years ago
|
Blocks: ls-shutdown-hangs
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93c355e248bb
LSNG: Force kill database actors during shutdown; r=asuth
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
|
|
Assignee | |
Updated•5 years ago
|
Crash Signature: [@ mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownWorkThreads::<T>::__invoke ]
|
|
Assignee | |
Updated•5 years ago
|
Crash Signature: [@ mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownWorkThreads::<T>::__invoke ] → [@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownTimedOut]
[@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownWorkThreads::$_15::__invoke]
[@ mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownTimedOut]
[@ mozilla::dom::`an…
|
|
Assignee | |
Updated•5 years ago
|
Crash Signature: [@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownTimedOut]
[@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownWorkThreads::$_15::__invoke]
[@ mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownTimedOut]
[@ mozilla::dom::`an… → [@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownTimedOut]
[@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownWorkThreads::$_15::__invoke]
[@ mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownWorkThreads::<T>::__invoke]
|
|
Assignee | |
Comment 4•5 years ago
|
||
Comment on attachment 9100290 [details]
Bug 1587931 - LSNG: Force kill database actors during shutdown; r=asuth
Beta/Release Uplift Approval Request
- User impact if declined: Users experience more shutdown hangs
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): Medium risk given we are very close to 70 release. The patch is quite simple though and Nightly shows significant reduction of shutdown hangs.
- String changes made/needed: None
Attachment #9100290 -
Flags: approval-mozilla-release?
|
|
Assignee | |
Comment 5•5 years ago
|
||
Just to be clear, the patch would be intended for Firefox 70 uplift.
|
|
Assignee | |
Comment 6•5 years ago
|
||
Database actors are force killed after 5 seconds if the child side doesn't
respond to the RequestAllowToClose message during shutdown.
|
|
Assignee | |
Comment 7•5 years ago
|
||
The last attachment is for potential 70 branch uplift.
|
|
Assignee | |
Comment 8•5 years ago
|
||
Comment on attachment 9100827 [details]
Bug 1587931 - LSNG: Force kill database actors during shutdown; r=asuth
Beta/Release Uplift Approval Request
- User impact if declined: Users experience more shutdown hangs
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): Medium risk given we are very close to 70 release. The patch is quite simple though and Nightly shows significant reduction of shutdown hangs.
- String changes made/needed: None
Attachment #9100827 -
Flags: approval-mozilla-release?
|
|
Assignee | |
Updated•5 years ago
|
Attachment #9100290 -
Flags: approval-mozilla-release?
|
|
Assignee | |
Updated•5 years ago
|
Crash Signature: [@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownTimedOut]
[@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownWorkThreads::$_15::__invoke]
[@ mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownWorkThreads::<T>::__invoke] → [@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownTimedOut]
[@ mozilla::dom::(anonymous namespace)::QuotaClient::ShutdownWorkThreads::$_15::__invoke]
[@ mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownTimedOut]
[@ mozilla::dom::`an…
|
|
Assignee | |
Comment 9•5 years ago
|
||
This fix significantly reduced LocalStorage shutdown hangs.
status-firefox70:
--- → affected
Comment on attachment 9100827 [details]
Bug 1587931 - LSNG: Force kill database actors during shutdown; r=asuth
Getting rid of some of those crashes would be great, let's take this gamble.
Attachment #9100827 -
Flags: approval-mozilla-release? → approval-mozilla-release+
status-firefox69:
--- → unaffected
|
||
Comment 11•5 years ago
|
||
| bugherder uplift | ||
Crash Signature: mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownWorkThreads::<T>::__invoke] → mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownWorkThreads::<T>::__invoke]
[@ static void mozilla::dom::`anonymous namespace'::QuotaClient::ShutdownWorkThreads::<T>::operator()::<T>::__invoke]
|
|
Assignee | |
Comment 12•5 years ago
|
||
This didn't regress bug 1592336, it actually reduced shutdown hangs.
|
||
Updated•4 years ago
|
Attachment #9100827 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•