Closed Bug 1588065 Opened 5 years ago Closed 5 years ago

Fix compile errors after bug 1578624

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 3 obsolete files)

+++ This bug was initially created as a clone of Bug #1578624 +++

I'm getting compile errors compiling Thunderbird:
0:27.14 c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/include\nsDocShellLoadState.h(364,3): error: no template named 'Maybe'; did you mean 'mozilla::Maybe'?
0:27.14 Maybe<nsCString> mOriginalURIString;

The attached patch seems to fix it.

Attached patch m-c-fix.patch (obsolete) (deleted) — Splinter Review

Sadly TB is busted, so can we fix this asap.

Assignee: nobody → jorgk
Attachment #9100424 - Flags: feedback?(matt.woodrow)
Attachment #9100424 - Flags: feedback?(matt.woodrow) → feedback+

Could you please arrange for this to get landed (and also fix the typo in the commit message).

Attached patch m-c-fix.patch (obsolete) (deleted) — Splinter Review

Fixed commit message.

Attachment #9100424 - Attachment is obsolete: true
Attachment #9100662 - Attachment is obsolete: true
Attachment #9100661 - Attachment is obsolete: true
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/integration/autoland/rev/25cadf000372 Fix namespace issues in nsDocShellLoadState.h. r=mattwoodrow
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: