Profiler not reading android symbols
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox67 unaffected, firefox68 unaffected, firefox69 unaffected, firefox70 unaffected, firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox67 | --- | unaffected |
firefox68 | --- | unaffected |
firefox69 | --- | unaffected |
firefox70 | --- | unaffected |
firefox71 | --- | fixed |
People
(Reporter: jnicol, Assigned: gregtatum)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The about:debugging profiler, connected via USB to an android device, is not reading the symbols from my local android build properly. I have correctly added the objdir to the local build section.
I used mozregression on the desktop version of firefox, and found this regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6baef669e147828062e93a6e7edec259853e7304&tochange=f44e632769d75b428d0a84a3274bdf45095b91fc (bug 1581975 presumably)
This is on Linux, and I'm profiling a local build of geckoview_example. The phone is a Pixel 2 running android 9. I think it also affects non-local builds too, because I originally tried to use mozregression on geckoview_example rather than the desktop browser, but even old versions of that (along with an up to date nightly on desktop) didn't show symbols
Assignee | ||
Comment 1•5 years ago
|
||
The function had the wrong argument parameters, and it wasn't
fetching the latest list of objdirs.
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Hey jnicol, could you please try the patch locally and see if this fixes the problem for you? If yes I'll land it before Greg comes back from PTO to unblock you.
Reporter | ||
Comment 3•5 years ago
|
||
Hi Julien, I can confirm the patch fixes the problem.
Thanks both of you!
Comment 5•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Updated•5 years ago
|
Updated•3 years ago
|
Description
•