Closed Bug 1588114 Opened 5 years ago Closed 5 years ago

Implement Network.setCookie and Network.setCookies

Categories

(Remote Protocol :: CDP, task, P1)

Product:
Remote Protocol
Component:
CDP
Type:
task

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 5 open bugs,
URL
)

Details

(Whiteboard: [puppeteer-beta-mvp])

Attachments

(1 file, 2 obsolete files)

Bug 1588114 - [remote] Implement Network.setCookie and Network.setCookies.
(deleted), text/x-phabricator-request
Details

Adding a cookie we also had to do for Marionette, so pieces of this work could just be picked from:
https://searchfox.org/mozilla-central/source/testing/marionette/cookie.js

Specs for this method can be found at:
https://chromedevtools.github.io/devtools-protocol/tot/Network#method-deleteCookies

Here the interface of the add() cookie API:

https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/netwerk/cookie/nsICookieManager.idl#114

Note that some pre-processing might be necessary to distinguish between the url or host/path variations.

Mentor: hskupin
Priority: P2 → P3
Whiteboard: [lang=js]
Assignee: nobody → dburns

This adds the methods setCookie and setCookies to the Network interface
of the remote protocol

This adds the methods setCookie and setCookies to the Network interface
of the remote protocol

Attachment #9113719 - Attachment is obsolete: true
Attachment #9113719 - Attachment is obsolete: false
Blocks: 1604723
Priority: P3 → P1
Whiteboard: [lang=js] → [lang=js][puppeteer-beta-reserve]
Status: NEW → ASSIGNED
Blocks: 1613883
Assignee: dburns → hskupin
Mentor: hskupin
Whiteboard: [lang=js][puppeteer-beta-reserve] → [puppeteer-beta]
Attachment #9113719 - Attachment is obsolete: true
Blocks: 1549461
Summary: Implement Network.setCookie → Implement Network.setCookie and Network.setCookies
Whiteboard: [puppeteer-beta] → [puppeteer-beta-mvp]
Blocks: 1613952
Attachment #9114144 - Attachment is obsolete: true
Blocks: 1614042
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/686af4c3274d [remote] Implement Network.setCookie and Network.setCookies. r=remote-protocol-reviewers,maja_zf

https://hg.mozilla.org/mozilla-central/rev/686af4c3274d

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Component: CDP: Network → CDP
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: