Closed Bug 1588154 Opened 5 years ago Closed 5 years ago

Turn on/enable service worker parent interception ("dom.serviceWorkers.parent_intercept") by default

Categories

(Core :: DOM: Service Workers, enhancement, P2)

Product:
Core
Component:
DOM: Service Workers
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla73
Project Flags:
Fission Milestone M5
Tracking Flags:
Tracking Status
firefox70 --- wontfix
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- verified

People

(Reporter: ehsan.akhgari, Assigned: perry)

References

(Blocks 5 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

Bug 1588154 - make dom.serviceWorkers.parent_intercept true by default r?asuth
(deleted), text/x-phabricator-request
Details
Bug 1588154 - remove invalid comment for SW pref r?#dom-workers-and-storage-reviewers
(deleted), text/x-phabricator-request
Details

This bug keeps track of turning on the dom.serviceWorkers.parent_intercept pref by default.

Blocks: 1503787
Blocks: 1583700
No longer blocks: document-channel
Priority: -- → P2
Blocks: ServiceWorkers-e10s
Depends on: 1589708, 1456995
Summary: Turn on service worker parent interception by default → Turn on/enable service worker parent interception ("dom.serviceWorkers.parent_intercept") by default

Currently the plan is for this is to ride with DocumentChannel and no earlier than Firefox 73. Bug 1583700 only enabled DocumentChannel on nightly, there doesn't seem to yet be a bug for letting it ride the trains.

status-firefox70: --- → wontfix
status-firefox71: --- → wontfix
status-firefox72: --- → wontfix
Blocks: 1596682

serviceworker_e10s blocks DocumentChannel (bug 1596682) and thus blocks Fission dogfooding (milestone M5).

Fission Milestone: --- → M5
status-firefox73: --- → affected
Assignee: nobody → perry
Pushed by pjiang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99d782b09b7d make dom.serviceWorkers.parent_intercept true by default r=asuth,jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20911 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Blocks: 1605587
Blocks: 1605583
Blocks: 1603402
Blocks: 1605581
Blocks: 1605580
Blocks: 1605579
Blocks: 1605577
Blocks: 1605573

https://hg.mozilla.org/mozilla-central/rev/99d782b09b7d

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Upstream PR merged by moz-wptsync-bot
Flags: qe-verify+

The pref "dom.serviceWorkers.parent_intercept" is set on true by default on Firefox 73.0b2 (20200107212705) on Windows 10x64, macOS 10.15 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox73: fixed → verified
Flags: qe-verify+
Regressions: 1608716
Depends on: 1603484
Depends on: 1610501
Regressions: 1607276

Hi Perry, we should probably remove/change this comment here, too?

Flags: needinfo?(perry)
Flags: needinfo?(perry)

Not sure why it doesn't appear below "Phabricator Revisions", but the removal change is at https://phabricator.services.mozilla.com/D75318

Attachment #9148952 - Attachment is obsolete: true
Pushed by pjiang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e29dcd343df remove invalid comment for SW pref r=dom-workers-and-storage-reviewers,asuth
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: