Open Bug 1588286 Opened 5 years ago Updated 4 years ago

private browsing default search engine notice is very bright in dark mode

Categories

(Firefox :: Search, enhancement, P5)

enhancement

Tracking

()

Tracking Status
firefox71 --- affected

People

(Reporter: heycam, Assigned: ke5trel)

References

(Blocks 2 open bugs)

Details

(Keywords: blocked-ux)

Attachments

(3 files)

Attached image screen shot (deleted) —

See the attached screen shot. The message showing the new search engine setting for private browsing windows could do with some dark mode styling.

Type: defect → enhancement
Flags: needinfo?(mverdi)
Keywords: blocked-ux
Assignee: nobody → ke5trel
Attached image Post-patch screenshot (deleted) —
Attachment #9100810 - Attachment is patch: false
Attachment #9100810 - Attachment mime type: text/plain → image/png

Michael, can you sign-off on the post-patch screenshot? Let me know if you need a try build.

Note: The patch is also changing the search box, not just the banner.

Priority: -- → P2

(In reply to Mark Banner (:standard8) from comment #3)

Michael, can you sign-off on the post-patch screenshot? Let me know if you need a try build.

Let's hold off on this for a bit. We're working on the search field in Bug 1574734 and I want to use different colors for that banner (still working on it).

Flags: needinfo?(mverdi)

Delayed for now, but we'll look at it before we ship the feature.

Priority: P2 → P5
Severity: normal → N/A
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: