Closed
Bug 1588741
Opened 5 years ago
Closed 5 years ago
Descriptors.getTarget races when called in parallel
Categories
(DevTools :: Framework, defect, P2)
DevTools
Framework
Tracking
(firefox72 fixed)
RESOLVED
FIXED
Firefox 72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
When calling FrameDescriptor.getTarget or ProcessDescriptor.getTarget concurrently, you may have access to a target that is still in process of attaching:
https://searchfox.org/mozilla-central/rev/17756e2a5c180d980a4b08d99f8cc0c97290ae8d/devtools/shared/fronts/descriptors/frame.js#59-60
if (this._frameTargetFront && this._frameTargetFront.actorID) {
return this._frameTargetFront; /// <<=== here we may return the unattached target
}
if (this._targetFrontPromise) {
return this._targetFrontPromise;
}
this._targetFrontPromise = (async () => {
...
this._frameTargetFront = await this._createFrameTarget(targetForm); // <== here we save the unattached target
await this._frameTargetFront.attach();
The same pattern is used for processes:
https://searchfox.org/mozilla-central/source/devtools/shared/fronts/descriptors/process.js#66
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9101230 -
Attachment description: Bug 1588741 - Fix a race when calling descriptor.getTarget in parallel. → Bug 1588741 - Descriptors.getTarget may return unattached targets when called in parallel.
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → poirot.alex
|
|
Assignee | |
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=28599c2dcd3b5fcc4554363dd3d59b0457b6e236
(the try run includes bug 1471754, which introduces failures)
|
||
Updated•5 years ago
|
Summary: Descriptots.getTarget races when called in parallel → Descriptors.getTarget races when called in parallel
|
||
Updated•5 years ago
|
Priority: -- → P2
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f546e70e68e
Descriptors.getTarget may return unattached targets when called in parallel. r=jdescottes
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•