"Messages" tab is not translated on RTL build
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(Not tracked)
People
(Reporter: rpopovici, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
Preconditions:
Nightly - RTL build(71.0a1)
Set 'devtools.netmonitor.features.webSockets' to "true" in about:config and after that restart the browser.
Steps to reproduce:
- Launch Firefox browser
- Navigate to: http://janodvarko.cz/test/websockets/
- Press F12 to open Devtools
- Go to the Network tab
- Press "Connect" button from the page opened in step 2
- Click on "http://echo.websocket.org" websocket request
- Click on "Messages" panel
- Type a message and press "Send" button from the page opened in step 2
Actual result:
"Messages" tab is not translated. Time is not correctly displayed.
Expected result:
"Messages" tab should be translated. Time should be correctly displayed.
Comment 2•5 years ago
|
||
Francesco, does this mean that is hasn't been translated yet?
I think that it's properly implemented code-wise:
- The panel title is defined here:
https://searchfox.org/mozilla-central/rev/9df2ccc256fe54c314b34e52920471a0d04b283e/devtools/client/netmonitor/src/components/TabboxPanel.js#37 - The translation is here:
https://searchfox.org/mozilla-central/rev/9df2ccc256fe54c314b34e52920471a0d04b283e/devtools/client/locales/en-US/netmonitor.properties#795
Honza
Comment 3•5 years ago
|
||
Correct, and I would normally close bugs for incomplete localizations as INVALID, since there's no commitment to ship 100% localization.
If you really want to test RTL, in general Hebrew is a better pick
https://transvision.mozfr.org/string/?entity=devtools/client/netmonitor.properties:netmonitor.tab.messages&repo=gecko_strings
From the screenshot, that looks like Arabic, "RTL Build" is not really a thing.
Comment 4•5 years ago
|
||
Thanks for the update Francesco!
Closing as invalid, we'll just need to wait for the localization.
Honza
Description
•