Closed Bug 1588861 Opened 5 years ago Closed 5 years ago

XDR encoding modules

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: caroline, Assigned: caroline)

References

Details

Attachments

(5 files, 2 obsolete files)

Bug 1588861 - Part 1: Store index into gcThings instead of RootedFunction for FunctionDeclarations inside modules. r=iain
(deleted), text/x-phabricator-request
Details
Bug 1588861 - Part 2: Pull CreateArray out of ModuleBuilder and into js namespace. r=iain
(deleted), text/x-phabricator-request
Details
Bug 1588861 - Part 3: Add support for xdr encoding modules into xdr cache. r=iain
(deleted), text/x-phabricator-request
Details
Bug 1588861 - Part 4: Add test harness for xdr modules. r=iain
(deleted), text/x-phabricator-request
Details
Bug 1588861 - Part 5: Tests for xdr modules. r=iain
(deleted), text/x-phabricator-request
Details

Currently modules are not being XDRed, and thus do not yet exist in XDR byte cache. Having modules XDRed will allow us to save on module parse time and will eventually allow us to cache standard modules instead of JSM.

Priority: -- → P3
Blocks: 1459770
No longer depends on: 1459770

Depends on D53755

Depends on D53756

Assignee: nobody → ccullen
Attachment #9109853 - Attachment is obsolete: true
Attachment #9109854 - Attachment is obsolete: true

Depends on D54158

Depends on D55596

Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c1eec2b6d898 Part 1: Store index into gcThings instead of RootedFunction for FunctionDeclarations inside modules. r=iain https://hg.mozilla.org/integration/autoland/rev/639290e9ff22 Part 2: Pull CreateArray out of ModuleBuilder and into js namespace. r=iain https://hg.mozilla.org/integration/autoland/rev/2a0aacbd11de Part 3: Add support for xdr encoding modules into xdr cache. r=iain,tcampbell https://hg.mozilla.org/integration/autoland/rev/b622095c76ab Part 4: Add test harness for xdr modules. r=iain https://hg.mozilla.org/integration/autoland/rev/815a452c73af Part 5: Tests for xdr modules. r=iain

Assuming this sticks, what else needs to happen for ES modules loaded by the browser in content windows at startup time (eg about:home) to start being cached? Anything?

Flags: needinfo?(ccullen)

This is the foundation for that, but needs to be hooked into the ScriptLoader.

Flags: needinfo?(ccullen) → needinfo?(tcampbell)

Moved blocking bugs to Bug 1602931.

No longer blocks: 1459770, 1522042
Flags: needinfo?(tcampbell)

Thanks for doing this work, Caroline!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: