[Wayland] Bracket CPU read/write sequences by DMA_BUF_IOCTL_SYNC
Categories
(Core :: Widget: Gtk, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Pekka Paalanen at wayland-devel list about dma buf access:
Lock/Unlock:
An important detail is that you must use DMA_BUF_IOCTL_SYNC to
bracket your actual CPU read/write sequences to the dmabuf. That ioctl
will ensure the appropriate caches are flushed correctly (you might not
notice anything wrong on x86, but on other hardware forgetting to do
that can randomly result in bad data), and I think it also waits for
implicit fences (e.g. if you had GPU write to the dmabuf earlier, to
ensure the operation finished).
Assignee | ||
Comment 1•5 years ago
|
||
Looks like we don't need that as far as we use gbm_bo_map() instead of mmap().
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bec939498aa9
[Wayland] Remove misleading comment about DMA_BUF_IOCTL_SYNC, r=jhorak
Comment 4•5 years ago
|
||
bugherder |
Description
•