Closed Bug 1589224 Opened 5 years ago Closed 4 years ago

PiP toggle is hidden by extension on Twitch

Categories

(Toolkit :: Video/Audio Controls, enhancement, P3)

70 Branch
enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1608425

People

(Reporter: adamopenweb, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image Screenshot default position (deleted) —

When using Twitch, many popular streamers use extensions that cover the PiP toggle in Firefox.

This bug is to investigate:

  1. Programatically detecting that the extensions are active and the position of them
  2. If the extension position is mostly consistent on the right side middle across streamers
  3. If we can position the toggle slightly below these extensions with the Webcompat add-on
Attached image Screenshot new position (example) (deleted) —

Nik, see the description above. Wondering if there are ways for us to avoid overlapping our Picture in Picture toggle with Twitch extensions?

We have the ability to target JS/CSS interventions by domain with our Web Compatibility add-on. Want to provide a better experience on Twitch when we launch in FF 71.

Flags: needinfo?(purushen)

Hi Adam is there any api or way to determine where this button would appear?

No. The button will appear in the same location for all videos. Was hoping we could work around the Twitch extensions, just for Twitch, as they seem to show up in that same position on many popular streamers channels.

Blocks: videopip
Priority: -- → P3

Hey, twitch front-end developer here. Would love to have this looking looking and working better on twitch, but simply moving the element down a bit as in the new position example won't be a good solution. There can be a variable number of extensions icons in that dock on the right-hand side depending on how a broadcaster has their channel configured. Please prioritize bug 1550453 or some mechanism to disable the button entirely so we can include a PIP button as part of our own controls. (Site note: It seems like the current iteration of this feature also simply ignores the disablePictureInPicture attribute on the video tag?)

I think this is a duplicate of fixed bug 1608425

Flags: needinfo?(astevenson)

Thanks Mathew, I think so as well. Closing as duplicate.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(purushen)
Flags: needinfo?(astevenson)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: