Closed Bug 1589447 Opened 5 years ago Closed 5 years ago

Add network id change event (linux)

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: kershaw, Assigned: michal)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Add a new topic network:network-id-changed to notify that network id is changed.

Blocks: 1567627
Assignee: nobody → michal.novotny
Priority: -- → P2
Whiteboard: [necko-triaged]

This patch splits network change event into 2 events:

  1. network ID change event
    It is sent when the calculated ID differs from the previous one.

  2. network change event
    It is sent when the network ID has changed or when any address has been added, removed or changed.

Pushed by mnovotny@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/abdcdc97cd4c Add network id change event (linux), r=kershaw
Attachment #9103789 - Attachment description: Bug 1589447 - Add network id change event (linux), r?valentin → Bug 1589447 - Add network id change event on Linux and Android, r=valentin

I have no idea why the original patch causes the wpt failure. I tried couple of changes in the patch on try and the test fails when we send network change event when some address is modified, i.e. the same logic that was in the old code before NetlinkService was implemented https://searchfox.org/mozilla-central/rev/8afaba205627ff1b20bd6205119d301f3932cff6/netwerk/system/linux/nsNotifyAddrListener_Linux.cpp#440. I don't know why the test didn't fail with the old code. Maybe the combination of the test and platform didn't exist at that time? Anyway, I decided simply to not modify network change event and just to add the new network ID change event which is then equal to network change event on those platforms.

Flags: needinfo?(michal.novotny)
Pushed by mnovotny@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20eae859997f Add network id change event on Linux and Android, r=kershaw,valentin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
QA Whiteboard: [qa-72b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: