Closed Bug 1589591 Opened 5 years ago Closed 2 years ago

ArrayEqual/EqualChars distinction is no longer necessary

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED DUPLICATE of bug 1780010

People

(Reporter: jandem, Unassigned)

Details

It used to be that we had PodEqual and it required both arguments to have the same type, so I added EqualChars for use when this is not true (typically when comparing Latin1Char and char16_t strings). However, we now use ArrayEqual instead of PodEqual, and EqualChars also just calls ArrayEqual.

In other words, using both functions depending on argument types like we do here is no longer necessary.

Waldo, do you feel like we should just use mozilla::ArrayEqual directly? I don't care much, I just don't like using both in the same code.

Flags: needinfo?(jwalden)
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(jwalden)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.