Implement Network.loadingFailed
Categories
(Remote Protocol :: CDP, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: impossibus, Unassigned)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [puppeteer-beta2-mvp])
https://chromedevtools.github.io/devtools-protocol/tot/Network#event-loadingFailed
Example:
{"method":"Network.loadingFailed","params":{"requestId":"1000019154.7022","timestamp":519853.465592,"type":"Fetch","errorText":"net::ERR_INTERNET_DISCONNECTED","canceled":false}
Comment 1•5 years ago
|
||
It looks like Gutenberg is observing the contents of the errorText
field )-:
Comment 2•5 years ago
|
||
Given the frequency of usage via https://wiki.mozilla.org/Remote/GutenbergCDPUsage#Events this comes at the very ending of the list. So I don't think it is important right now to get implemented.
Reporter | ||
Comment 3•5 years ago
|
||
This is among the events we see in a gutenberg run: https://wiki.mozilla.org/Remote/PuppeteerCDPUsage#In_Wordpress_gutenberg_test_suite
Comment 4•5 years ago
|
||
So what's the difference between those different sites, and especially what does the "In Wordpress gutenberg test suite" section mean compared to the events as listed on GutenbergCDPUsage?
Reporter | ||
Comment 5•5 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #4)
So what's the difference between those different sites, and especially what does the "In Wordpress gutenberg test suite" section mean compared to the events as listed on GutenbergCDPUsage?
It's the subset of events encountered during a gutenberg run that are also used somehow in Puppeteer. So to support gutenberg's use of Puppeteer, it makes sense to prioritize those events over others. As we investigate how the events are actually used, we might change the priority.
In the case of loadingFailed, it's relatively infrequent because we usually expect resources to load successfully in a test, but it might be used as part of error handling in test suite setup, for example.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 6•5 years ago
|
||
This event gets emitted because Puppeteer by default enables the Network
domain. But it doesn't look like that the RequestFailed
event from Puppeteer is used by Gutenberg. I would suggest we keep it of the track for Gutenberg for now.
Comment 7•4 years ago
|
||
We might be able to use the http-on-failed-opening-request
observer notification similar to devtools to detect security check failures:
Comment 8•4 years ago
|
||
See also bug 1638259 comment 21 for issues with CSP and loading resouces like style sheets.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•2 years ago
|
Description
•