I just updated to macOS 10.15 Catalina and Xcode 11.1. I'm now hitting a mach configure error:

DEBUG: Executing: `pkgutil --pkg-info com.apple.pkg.CLTools_Executables`
DEBUG: The command returned non-zero exit status 1.
DEBUG: Its error output was:
DEBUG: | No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.
ERROR: Could not find installed Xcode Command Line Tools; run `xcode-select --install` and follow the instructions to install them then try again; if you wish to build without Xcode Command Line Tools installed, add the --disable-xcode-checks configure flag

But I have Xcode Command Line Tools installed. xcode-select --install says "error: command line tools are already installed, use "Software Update" to install updates". Also, my mozconfig is set to use mozbuild's vendored clang builds, not Xcode clang.

Haik says he hit this same configure error when first started testing Calatina betas. Adding ac_add_options --disable-xcode-checks to his mozconfig made the problem go away. I haven't tried that yet, but disabling Xcode checks seems like something we shouldn't do. :)

but disabling Xcode checks seems like something we shouldn't do.

Actually, it feels like we can remove it entirely. It was added in bug 1366564 2 years ago, and that was before bug 1522931, which now detects the SDK with xcrun, and all the recent changes to how bindgen is hooked up.

I haven't been able to reproduce this. I did encounter the error message in the Description, but running xcode-select --install fixed it. ac_add_options --disable-xcode-checks didn't seem to do anything however. (The build continued from this point and eventually failed, but for reasons that seem to be unrelated to this bug.)

cpeterson, are you still seeing this? If so, have you confirmed that --disable-xcode-checks fixes this issue for you? If it does then I can look at removing these Xcode checks but right now I'm uncertain that it will actually solve your problem.

cpeterson, are you still seeing this? If so, have you confirmed that --disable-xcode-checks fixes this issue for you? If it does then I can look at removing these Xcode checks but right now I'm uncertain that it will actually solve your problem.

Yes. --disable-xcode-checks "fixes" the problem for me and I can then build successfully. If I remove --disable-xcode-checks, the error returns.

Running xcode-select --install still returns the error xcode-select: error: command line tools are already installed, use "Software Update" to install updates. I have the latest Xcode Version 11.1 (11A1027) installed and there are no updates available in the System Preferences' "Software Update" panel.

(In reply to Mike Hommey [:glandium] (high latency) from comment #1)

but disabling Xcode checks seems like something we shouldn't do.

Actually, it feels like we can remove it entirely. It was added in bug 1366564 2 years ago, and that was before bug 1522931, which now detects the SDK with xcrun, and all the recent changes to how bindgen is hooked up.

Should bug 1522931 be marked as fixed?

👍 I verified that this patch fixes the configure problem on my machine.

https://hg.mozilla.org/mozilla-central/rev/e33406683548