Force LTR the pref values on the search bar in about:config
Categories
(Toolkit :: Preferences, defect, P3)
Tracking
()
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
References
(Blocks 1 open bug)
Details
(Keywords: rtl)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
This is a follow-up on bug 1589352, to fix the third issue mentioned here:
https://phabricator.services.mozilla.com/D49828#1512253
... and also to make the pref on the .deleted
row LTR.
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8ae63cee3ee1
Always display preference values on the search bar in the left-to-right direction. r=Itiel
Comment 3•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Comment on attachment 9102762 [details]
Bug 1589899 - Always display preference values on the search bar in the left-to-right direction. r=paolo
Beta/Release Uplift Approval Request
- User impact if declined: While typing preference names in right-to-left mode, the last dot would appear at the opposite side of the input box.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: This requires a version of Firefox in a right-to-left language. Check that, while typing a preference name containing a dot, the last dot appears correctly.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This fix was developed on a right-to-left build and reviewed on a left-to-right build, so it would probably turn out to be correct at the time of verification.
- String changes made/needed: None
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Comment on attachment 9102762 [details]
Bug 1589899 - Always display preference values on the search bar in the left-to-right direction. r=paolo
Low risk css fix for ltr builds, uplift approved for 71 beta 6, thanks.
Comment 6•5 years ago
|
||
bugherder uplift |
Comment 7•5 years ago
|
||
Reproduced this issue on Windows 10, MacOS 10.14 and Ubuntu 18.04 using Firefox Beta 70.0b5 (20191028110005)
Also verified it using Firefox Beta 70.0b6 (20191031113544) and it has been fixed.
Description
•