Enable dom/tests/browser/browser_persist_cookies.js for Fission
Categories
(Core :: DOM: Security, task, P2)
Tracking
()
Fission Milestone | M4.1 |
People
(Reporter: hsinyi, Assigned: farre)
References
(Blocks 1 open bug)
Details
(Whiteboard: [domsecurity-backlog1])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Reporter | ||
Comment 1•5 years ago
|
||
Hi Gijs, you helped to add the test in bug 1469916. Would you please take a look and help to enable this for Fission? Thank you.
Comment 2•5 years ago
|
||
This is because the underlying feature (saving documents / nsiwebbrowserpersist) and its frame walking is broken with cross-origin iframes. We can't do anything to fix this test until that's happened.
Comment 3•5 years ago
|
||
For reference, I used this to debug the test a bit.
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.
This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:
0ee3c76a-bc79-4eb2-8d12-05dc0b68e732
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Hsin-Yi says this is a long-time unowned area and making it Fission-compatible is not trivial work. A Fission engineer familiar with BrowsingContext and DocShell should probably take this bug.
This bug breaks front-end's document saving.
Comment 6•5 years ago
|
||
Thanks for taking this up, Andreas.
Comment 7•5 years ago
|
||
Hey Andreas, I am currently evaluating open bugs within dom:security that are blocking fission. It seems the test browser_persist_cookies.js is not annotated as failing when fission enabled anymore.
Is there anything left to do within this bug or can we close it?
Assignee | ||
Comment 8•4 years ago
|
||
Yeah, sorry about that. Closed it! Thanks for bringing it to my attention.
Description
•