Closed Bug 1590250 Opened 5 years ago Closed 5 years ago

network ID: different ID is detected after re-enabling mobile data

Categories

(Core :: Networking, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
mozilla72
Tracking Status
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 --- wontfix
firefox72 --- verified

People

(Reporter: michal, Assigned: michal)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

Testing shows that GW on mobile data is often different after disabling and enabling the data. The changes in bug 1585920 caused that when using mobile data we hash link name as well as IP of GW at https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/netwerk/system/netlink/NetlinkService.cpp#1623. That code should cover VPN tunnels so we should avoid hashing linkname+IP when we used this interface at https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/netwerk/system/netlink/NetlinkService.cpp#1521.

For same reason, there are artificial MAC addresses available on some non-ethernet link devices. With this patch we ignore all neighbor messages for non-ethernet links. Also, when traffic for the checked host is routed via rmnet_data device, we skip hashing IP of next hop, because it changes very often in case of some mobile providers.

Pushed by mnovotny@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afba5a084fe4 network ID: different ID is detected after re-enabling mobile data, r=valentin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Does this need a Beta uplift request or can this ride Fx72 to release?

This probably doesn't need to be uplifted. Network change is detected and having different ID for the same network isn't critical.

Flags: needinfo?(michal.novotny)

Hi, verified as fixed with Google Pixel 3a (Android 9) on Fenix/Firefox Preview Nightly 191029 (Build #13020608) and Gecko View 72.0a1-20191025095546.
I will mark the ticket as Verified.

Status: RESOLVED → VERIFIED
Hardware: Unspecified → ARM
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: