Closed
Bug 1590465
Opened 5 years ago
Closed 5 years ago
Rust networking check breaks with TSan
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox72 fixed)
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: decoder, Assigned: decoder)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
There is a check in config/makefiles/rust.mk for ensuring that no network-related functions are imported from Rust code.
We have already disabled this check for fuzzing (when using sanitizer coverage) and for profiling, but we also need to disable it for TSan because the code breaks with the TSan interceptors for certain network functions. Doing so should not be a problem because these are test builds and the check is meaningless there.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cc012622051
Disable rust networking check with TSan. r=jseward
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•