On the groups_20020716_branch, the editgroups page has at least the following bad things :-) I'll file all these in one bug, since it's not trunk code yet and I don't want to bury you in a heap of reviewish nit bugs. - Action links (Edit / Delete) should have separator; I'd go for the vertical bar (|). - "Buggroup" needs to be cleared out. Wtf is a buggroup? (don't answer me, I'm playing the newbie admin here. :-)) - The "Add Group" link is in the wrong column; it should be in the action column, naturally. - You shouldn't allow people to edit the names of the predefined groups like editbugs; that will break bugzilla in no time. - The description of the Active Flag makes no sense for the system groups. You couldn't add bugs to "editcomponents" anyway. - The last paragraph ("In addition...") is no longer relevant, but in case you decide to use the text somewhere, s/rexexp/regexp/. :-)

Sounds like the concept of a buggroups needs to be revised to place the system groups in one category and the non-system groups in another. Since groups may be defined for things such as bless capability, there are probably 3 types. 0 - system groups --> can not edit/change, not used for bug-specific checkboxes 1 - bug groups --> can edit/change, can be used for bug-specific checkboxes 2 - administrative groups --> can edit/change, not used for bug-specific checkboxes The need for a distinction between type 1 and 2 goes away when "stage 3" is implemented.

These issues should all be addressed in the current branch tip. isbuggroup has been repl;aced by group_type

This batch is checked into the branch.

I'm going to go ahead and mark this as 2.18 to make my queries easy, since it's going to be merged with the trunk before 2.18 ships anyway