Closed Bug 1590774 Opened 5 years ago Closed 5 years ago

Perma OS X 10.14 debug TEST-UNEXPECTED-FAIL | leakcheck | default 59624839 bytes leaked (AbstractThread, AbstractWatcher, AnimationTimeline, AtomSet, AudioChannelAgent, ...) when Gecko 72 merges to Beta on 2019-12-02

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 72
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 + verified

People

(Reporter: apavel, Assigned: u608768)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1590774 - Fix shutdown leaks in browser_newWindowDrop.js, r=nika
(deleted), text/x-phabricator-request
Details

Central As beta simulation:

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=fa4b1c78a05778a89525fc26e90a519c52b6e40f&selectedJob=272553232

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272553232&repo=try&lineNumber=15504

[task 2019-10-23T12:02:37.182Z] 12:02:37 INFO - TEST-START | browser/base/content/test/general/browser_windowactivation.js
[task 2019-10-23T12:02:37.182Z] 12:02:37 INFO - GECKO(1723) | ++DOCSHELL 0x125743000 == 24 [pid = 1723] [id = {cb6ae192-4a6c-284d-b1da-51603dbfb879}]
[task 2019-10-23T12:02:37.182Z] 12:02:37 INFO - GECKO(1723) | ++DOMWINDOW == 155 (0x15e024a60) [pid = 1723] [serial = 625] [outer = 0x0]
[task 2019-10-23T12:02:37.182Z] 12:02:37 INFO - GECKO(1723) | ++DOMWINDOW == 156 (0x12588b800) [pid = 1723] [serial = 626] [outer = 0x15e024a60]
[task 2019-10-23T12:02:37.212Z] 12:02:37 INFO - GECKO(1723) | ++DOMWINDOW == 157 (0x15d0c5000) [pid = 1723] [serial = 627] [outer = 0x15e024a60]
[task 2019-10-23T12:02:37.639Z] 12:02:37 INFO - GECKO(1723) | ++DOCSHELL 0x127080800 == 25 [pid = 1723] [id = {61e09cf6-485a-7043-a652-f268f2aac47b}]
[task 2019-10-23T12:02:37.640Z] 12:02:37 INFO - GECKO(1723) | ++DOMWINDOW == 158 (0x15e024e20) [pid = 1723] [serial = 628] [outer = 0x0]
[task 2019-10-23T12:02:37.640Z] 12:02:37 INFO - GECKO(1723) | ++DOMWINDOW == 159 (0x159a0dc00) [pid = 1723] [serial = 629] [outer = 0x15e024e20]
[task 2019-10-23T12:02:37.640Z] 12:02:37 INFO - GECKO(1723) | --DOCSHELL 0x12450e000 == 1 [pid = 1728] [id = {7ead2dc0-8890-3341-8768-7cc71b367549}] [url = about:privatebrowsing]
[task 2019-10-23T12:02:37.640Z] 12:02:37 INFO - GECKO(1723) | --DOMWINDOW == 19 (0x14b6fb5c0) [pid = 1728] [serial = 421] [outer = 0x0] [url = http://example.com/browser/browser/base/content/test/general/browser_web_channel.html?unsolicited]
[task 2019-10-23T12:02:37.640Z] 12:02:37 INFO - GECKO(1723) | --DOMWINDOW == 18 (0x122b4f2e0) [pid = 1728] [serial = 411] [outer = 0x0] [url = http://example.com/browser/browser/base/content/test/general/browser_web_channel.html?twoway]
[task 2019-10-23T12:02:37.640Z] 12:02:37 INFO - GECKO(1723) | --DOMWINDOW == 17 (0x14b6fb020) [pid = 1728] [serial = 408] [outer = 0x0] [url = about:privatebrowsing]
[task 2019-10-23T12:02:37.640Z] 12:02:37 INFO - GECKO(1723) | --DOMWINDOW == 16 (0x14b6fb200) [pid = 1728] [serial = 414] [outer = 0x0] [url = http://example.com/browser/browser/base/content/test/general/browser_web_channel.html?iframe_pre_redirect]
[task 2019-10-23T12:02:37.640Z] 12:02:37 INFO - GECKO(1723) | --DOMWINDOW == 15 (0x14b6fb7a0) [pid = 1728] [serial = 424] [outer = 0x0] [url = http://example.com/browser/browser/base/content/test/general/browser_web_channel.html?unsolicited]
[task 2019-10-23T12:02:37.683Z] 12:02:37 INFO - GECKO(1723) | ++DOMWINDOW == 160 (0x15f650800) [pid = 1723] [serial = 630] [outer = 0x15e024e20]
[task 2019-10-23T12:02:38.659Z] 12:02:38 INFO - GECKO(1723) | --DOMWINDOW == 18 (0x14596dc00) [pid = 1731] [serial = 215] [outer = 0x0] [url = http://mochi.test:8888/browser/browser/base/content/test/general/browser_web_channel_iframe.html?iframe]
[task 2019-10-23T12:02:38.659Z] 12:02:38 INFO - GECKO(1723) | --DOMWINDOW == 17 (0x11e5cc400) [pid = 1731] [serial = 206] [outer = 0x0] [url = http://example.com/browser/browser/base/content/test/general/browser_web_channel.html?generic]
[task 2019-10-23T12:02:38.660Z] 12:02:38 INFO - GECKO(1723) | --DOMWINDOW == 16 (0x14592c800) [pid = 1731] [serial = 212] [outer = 0x0] [url = http://example.com/browser/browser/base/content/test/general/browser_web_channel.html?iframe]
[task 2019-10-23T12:02:38.660Z] 12:02:38 INFO - GECKO(1723) | --DOMWINDOW == 15 (0x14543cc00) [pid = 1731] [serial = 209] [outer = 0x0] [url = http://example.com/browser/browser/base/content/test/general

[task 2019-10-23T12:03:26.139Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 642 nsXPCWrappedJS
[task 2019-10-23T12:03:26.139Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 1 nsXPConnect
[task 2019-10-23T12:03:26.139Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 23 nsXULCommandDispatcher
[task 2019-10-23T12:03:26.139Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 48 nsXULControllers
[task 2019-10-23T12:03:26.140Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 47608 nsXULElement
[task 2019-10-23T12:03:26.140Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 646 nsXULPopupListener
[task 2019-10-23T12:03:26.140Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 1 nsXULPopupManager
[task 2019-10-23T12:03:26.140Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 5696 nsXULPrototypeAttribute
[task 2019-10-23T12:03:26.140Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 1 nsXULPrototypeCache
[task 2019-10-23T12:03:26.140Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 2 nsXULPrototypeDocument
[task 2019-10-23T12:03:26.140Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 1971 nsXULPrototypeNode
[task 2019-10-23T12:03:26.140Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 1 nsXULTooltipListener
[task 2019-10-23T12:03:26.141Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 1 nsZipArchive
[task 2019-10-23T12:03:26.141Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 1 nsZipReaderCache
[task 2019-10-23T12:03:26.141Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 5 xpc::CompartmentPrivate
[task 2019-10-23T12:03:26.141Z] 12:03:26 INFO - TEST-INFO | leakcheck | default leaked 1 xpcJSWeakReference
[task 2019-10-23T12:03:26.141Z] 12:03:26 INFO - TEST-UNEXPECTED-FAIL | leakcheck | default 59624839 bytes leaked (AbstractThread, AbstractWatcher, AnimationTimeline, AtomSet, AudioChannelAgent, ...)
[task 2019-10-23T12:03:26.141Z] 12:03:26 INFO -
[task 2019-10-23T12:03:26.141Z] 12:03:26 INFO - leakcheck | Processing leak log file /var/folders/tm/cppg4xls2913_hstn71npyt8000017/T/tmpTPXlOR.mozrunner/runtests_leaks_tab_pid1726.log
[task 2019-10-23T12:03:26.142Z] 12:03:26 INFO -
[task 2019-10-23T12:03:26.142Z] 12:03:26 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 1726
[task 2019-10-23T12:03:26.142Z] 12:03:26 INFO -
[task 2019-10-23T12:03:26.148Z] 12:03:26 INFO - |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
[task 2019-10-23T12:03:26.148Z] 12:03:26 INFO - | | Per-Inst Leaked| Total Rem|
[task 2019-10-23T12:03:26.148Z] 12:03:26 INFO - 0 |TOTAL | 35 0| 4851743 0|
[task 2019-10-23T12:03:26.148Z] 12:03:26 INFO -
[task 2019-10-23T12:03:26.148Z] 12:03:26 INFO - nsTraceRefcnt::DumpStatistics: 993 entries
[task 2019-10-23T12:03:26.148Z] 12:03:26 INFO - TEST-PASS | leakcheck | tab no leaks detected!
[task 2019-10-23T12:03:26.149Z] 12:03:26 INFO - leakcheck | Processing leak log file /var/folders/tm/cppg4xls2913_hstn71npyt8000017/T/tmpTPXlOR.mozrunner/runtests_leaks_tab_pid1732.log
[task 2019-10-23T12:03:26.149Z] 12:03:26 INFO -
[task 2019-10-23T12:03:26.149Z] 12:03:26 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 1732

This might be from bug 1578465, Kashav please take a look.

Flags: needinfo?(kmadan)
Summary: Perma TEST-UNEXPECTED-FAIL | leakcheck | default 59624839 bytes leaked (AbstractThread, AbstractWatcher, AnimationTimeline, AtomSet, AudioChannelAgent, ...) when Gecko 72 merges to Beta on 2019-12-02 → Perma OS X 10.14 debug TEST-UNEXPECTED-FAIL | leakcheck | default 59624839 bytes leaked (AbstractThread, AbstractWatcher, AnimationTimeline, AtomSet, AudioChannelAgent, ...) when Gecko 72 merges to Beta on 2019-12-02
Product: Firefox Build System → Firefox

So I'm fairly sure that this was caused by browser_newWindowDrop.js, probably for the same reason described here. Unsure why it's only leaking OS X.

Assignee: nobody → kmadan
Blocks: 1578465
Status: NEW → ASSIGNED
Flags: needinfo?(kmadan)

Adds a registerCleanupFunction parameter to BrowserTestUtils.browserLoaded so we
can unregister the load event listener and reject the promise during test
cleanup.

This was broken because waitForNewWindow adds an observer that fires for every
new window. The observer calls browserLoaded on all of these windows, and since
only one of them loads the URL we care about, we never unregister the event
listeners from the remaining windows.

Depends on D49001

Pushed by kmadan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6731460a1d5c Fix shutdown leaks in browser_newWindowDrop.js, r=nika

https://hg.mozilla.org/mozilla-central/rev/6731460a1d5c

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Status: RESOLVED → VERIFIED
status-firefox72: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: