Closed
Bug 1590826
Opened 5 years ago
Closed 5 years ago
Drop stdout workaround from Puppeteer clone
Categories
(Remote Protocol :: Agent, defect, P1)
Remote Protocol
Agent
Tracking
(firefox72 fixed)
RESOLVED
FIXED
Firefox 72
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
()
Details
(Whiteboard: [puppeteer-alpha])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
We work around not being able to write to stderr in Puppeteer with the following workaround:
https://github.com/andreastt/puppeteer/commit/885e2e918f0d96871febbfd9c7d19e597ffdedc3
With bug 1543115 we can drop that patch from our fork.
Assignee | ||
Updated•5 years ago
|
Priority: -- → P3
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [puppeteer-alpha]
Assignee | ||
Comment 1•5 years ago
|
||
Full SHA-1: 2fff4ea08428842ad252a72bb3af30ab107fbd6c
Contains two commits reverting the stderr workaround, now that bug
1590826 prints to stderr.
Pushed by mjzffr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c6a5489cec98
remote: vendor puppeteer 2fff4ea; r=remote-protocol-reviewers,maja_zf
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•