Closed Bug 1590896 Opened 5 years ago Closed 5 years ago

Switch SearchService from using nsICollation to use localeCompare

Categories

(Firefox :: Search, task, P2)

task
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 75
Iteration:
75.2 - Feb 24 - Mar 8
Tracking Status
firefox75 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently we're using nsICollation to do a locale-sensitive string comparison:

https://searchfox.org/mozilla-central/rev/088e2cf29c59d733d57af43903eb0267dbf72e2a/toolkit/components/search/SearchService.jsm#2090-2097

We should switch this to localeCompare with the {sensitivity: 'base'} option. They do basically the same thing, but using localeCompare is better from JS.

This will also unblock making nsICollation non-scriptable (a separate bug).

Blocks: 1590860
Summary: Swith SearchService from using nsICollation to use localeCompare → Switch SearchService from using nsICollation to use localeCompare

I need this series of bugs for modernisation, taking.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Iteration: --- → 74.2 - Jan 20 - Feb 09
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94c8f28a15e8 Switch SearchService from using nsICollation to use localeCompare. r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Iteration: 74.2 - Jan 20 - Feb 09 → 75.2 - Feb 24 - Mar 8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: