Closed Bug 1591372 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19881 - [webnfc] toRecords() implementation

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19881 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19881
Details from upstream follow.

Leon Han <leon.han@intel.com> wrote:

[webnfc] toRecords() implementation

This CL adds support for reading sub records of a NDEFRecord,
i.e. NDEFRecord#toRecords().

Note: No support for writing yet.

The spec changes:
https://github.com/w3c/web-nfc/pull/333
https://github.com/w3c/web-nfc/pull/334
https://github.com/w3c/web-nfc/pull/359

BUG=520391

Change-Id: Ic7ac74416afa8e43f5293e4ca85e538fc700f3c6

Reviewed-on: https://chromium-review.googlesource.com/1824395
WPT-Export-Revision: 2dbb3b9ffa491231dc0addeea7d40be881ac9201

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 16 subtests

Firefox

OK : 1
FAIL: 16

Chrome

OK : 1
PASS: 4
FAIL: 12

Safari

OK : 1
FAIL: 16

New tests that's don't pass

/web-nfc/NDEFReader_scan.https.html
NDEFRecord.toRecords returns its embedded records correctly.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a9531f50510 [wpt PR 19881] - [webnfc] toRecords() implementation, a=testonly https://hg.mozilla.org/integration/autoland/rev/dfc5414fd3b5 [wpt PR 19881] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1a9531f50510
https://hg.mozilla.org/mozilla-central/rev/dfc5414fd3b5

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.