Closed
Bug 1591534
Opened 5 years ago
Closed 5 years ago
Should WR destroy all OS compositor surfaces before it shuts down?
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: mstange, Assigned: gw)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
At the moment, WR seems to leave some surfaces alive when it shuts down. It's possible that this is just due to bug 1591524.
Should we have an assertion in the OS compositor implementation that panics if any surfaces remain when the compositor is destroyed? Or should the OS compositor clean up any remaining surfaces on its own?
Flags: needinfo?(gwatson)
|
Assignee | |
Comment 1•5 years ago
|
||
I think WR should ensure that all surfaces are cleaned up.
Assignee: nobody → gwatson
Flags: needinfo?(gwatson)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef141fc2032a
Ensure native surfaces are destroyed on renderer deinit. r=kvark
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•