Remove unused DebuggerClient.requester API
Categories
(DevTools :: General, task, P3)
Tracking
(firefox72 fixed)
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jdescottes, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
With the removal of LongStringClient (Bug 1591330) and the deprecated ThreadClient (Bug 1591410), all the old style clients using DebuggerClient.requester have been removed.
We can remove this API defined at https://searchfox.org/mozilla-central/rev/74cc0f4dce444fe0757e2a6b8307d19e4d0e0212/devtools/shared/client/debugger-client.js#98 and check if we can remove any other dependency.
|
Assignee | |
Comment 1•5 years ago
|
||
This actually remove de main usage of DebuggerClient.request. It is still being used in a couple of other places:
https://searchfox.org/mozilla-central/search?q=.request(&case=false®exp=false&path=devtools%2F
The most problematic callsite is the following:
https://searchfox.org/mozilla-central/rev/652014ca1183c56bc5f04daf01af180d4e50a91c/devtools/shared/fronts/memory.js#82
Where the memory panel uses a Bulk Request. And protocol.js doesn't support bulk requests.
Getting rid of that one callsite would require some tweaks in order to support them in protocol.js... (bug 949595)
It is a bit unfortunate as all other usages of DebuggerClient.request can be removed and this holds from removing a significant part of DebuggerClient code.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
It looks like there is only networkEventUpdate which isn't 100% correctly typed.
It appears in specs, but one test (test_network_security-hpkp.html) is still failing if we remove it.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d4a5ae6a2da6
https://hg.mozilla.org/mozilla-central/rev/bf72bae6506a
https://hg.mozilla.org/mozilla-central/rev/8117461d135f
Description
•