Don't add `timestamp` for navigation events beside Page.domContentEventFired and Page.loadEventFired
Categories
(Remote Protocol :: CDP, defect, P3)
Tracking
(firefox72 fixed)
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: whimboo, Assigned: thomas510111, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Both Page.navigatedWithinDocument and Page.frameStoppedLoading should not emit the timestamp property:
|
Reporter | |
Comment 1•5 years ago
|
||
When making changes to this file make sure that all the browser-chrome tests are still passing by running the following command:
./mach test remote/test/browser/
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D51521
|
|
Assignee | |
Comment 3•5 years ago
|
||
This is my second bug.I run the test successfully,but somehow messed up and made this one depended to my first bug fix while it isnt.How can i fix this?
|
|
Reporter | |
Comment 4•5 years ago
|
||
Hi Thomas. Welcome and thank you for working on this bug! Good to see your interest.
When I have a look at the patch, I cannot find anything unusual. I assume you got it fixed meanwhile? If that is the case feel free to ask for review by using the "r=#remote!" suffix in the summary of the commit message. Thanks.
|
|
Assignee | |
Comment 5•5 years ago
|
||
I think i added you as a reviewer (is that what you were asking for?).
|
|
Reporter | |
Comment 6•5 years ago
|
||
Yes, that it is. Thanks, I will have a look at your patch tomorrow.
|
|
Reporter | |
Comment 8•5 years ago
|
||
Thomas, thanks a lot for your work!
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•