Closed Bug 1592121 Opened 5 years ago Closed 5 years ago

Crash in [@ webrender::batch::BatchBuilder::add_segment_to_batch]

Categories

(Core :: Graphics: WebRender, defect)

72 Branch
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 + fixed

People

(Reporter: calixte, Assigned: gw)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-2e2240e2-3ac9-4078-87cf-55e4d0191028.

Top 10 frames of crashing thread:

0 XUL gkrust_shared::panic_hook mfbt/Assertions.h:332
1 XUL core::ops::function::Fn::call src/libcore/ops/function.rs:69
2 XUL std::panicking::rust_panic_with_hook src/libstd/panicking.rs:481
3 XUL std::panicking::continue_panic_fmt src/libstd/panicking.rs:384
4 XUL rust_begin_unwind src/libstd/panicking.rs:311
5 XUL core::panicking::panic_fmt src/libcore/panicking.rs:85
6 XUL core::panicking::panic_bounds_check src/libcore/panicking.rs:61
7 XUL webrender::batch::BatchBuilder::add_segment_to_batch gfx/wr/webrender/src/batch.rs:2417
8 XUL webrender::batch::BatchBuilder::add_segmented_prim_to_batch gfx/wr/webrender/src/batch.rs:2481
9 XUL webrender::batch::BatchBuilder::add_prim_to_batch gfx/wr/webrender/src/batch.rs

There are 12 crashes (from 6 installations) in nightly 72 with buildid 20191028094851. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1590284.

[1] https://hg.mozilla.org/mozilla-central/rev?node=60e6c61a7f45

Flags: needinfo?(gwatson)

Do we have any URLs / repro steps for this one?

Flags: needinfo?(gwatson)
Flags: needinfo?(cdenizet)

All of them are google drive urls.

This prevents stale indices into the prim visibility scratch
buffer being reused on subsequent frames, which can cause various
unexpected code paths to be hit.

Assignee: nobody → gwatson
Flags: needinfo?(cdenizet)

Tracking for 72 given the volume

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59fc72700a93 Ensure prim instances in culled clusters are reset. r=nical
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: