Closed Bug 1592449 Opened 5 years ago Closed 4 years ago

nsILDAPConnection errors should be asynchronous

Categories

(Thunderbird :: General, enhancement)

Product:
Thunderbird
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr78 unaffected, thunderbird83 fixed)

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird83 --- fixed

People

(Reporter: benc, Assigned: benc)

References

Details

(Whiteboard: [fixed byg bug 1659947])

Currently, when LDAP operations are issued, it's assumed that any errors will immediately be returned synchronously as a result of calling the operation's method on nsLDAPOperation (eg SimpleBind()).

However, it's a network operation, so there are lots of things that can go wrong after this point. But there is currently no way to notify the calling code that something has gone wrong.
This will become more acute as more of the LDAP work goes async (required for Bug 1576364, to get the secure LDAP working again).

I think the way forward is to add an onLDAPError() method to nsILDAPMessageListener.

I don't think there are too many places to change - a search for onLDAPInit shows the listeners. There'll likely be some extra work to propagate and handle errors in the address-book LDAP code too.

Blocks: 1659947
Assignee: nobody → benc

Fixed by work over in Bug 1659947:
https://hg.mozilla.org/comm-central/rev/44e81d98aeb6

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
status-thunderbird83: --- → fixed
status-thunderbird_esr78: --- → affected
tracking-thunderbird_esr78: --- → +
Target Milestone: --- → 83 Branch
status-thunderbird_esr78: affected → unaffected
tracking-thunderbird_esr78: + → ---
Whiteboard: [fixed byg bug 1659947]
You need to log in before you can comment on or make changes to this bug.