Captured stack trace doesn't show async separator anymore
Categories
(DevTools :: Console, defect, P2)
Tracking
(firefox-esr68 wontfix, firefox70 wontfix, firefox71 wontfix, firefox72 verified)
People
(Reporter: Honza, Assigned: nchevobbe)
References
(Regression)
Details
(Keywords: dev-doc-complete, regression)
Attachments
(3 files)
Consider the following code:
function resolveAfter2Seconds() {
return new Promise((resolve) => {
setTimeout(() => {
console.trace();
resolve();
}, 2000);
});
}
async function waitForData() {
await resolveAfter2Seconds();
}
STR:
- Load the scrip within a page
- Select the Console panel
- Execute
waitForData()
in the command line.
The Console panel should show stack trace composed from sync and async frames. Those should be separated by an async message explaining what async op happend.
See the attached screenshot showing how it was working before.
Honza
Reporter | ||
Comment 1•5 years ago
|
||
Reporter | ||
Comment 2•5 years ago
|
||
@Brian: do you know what could be the problem here? It was working before no?
Honza
Reporter | ||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Comment 4•5 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #2)
@Brian: do you know what could be the problem here? It was working before no?
I don't, I'm not familiar with how the console deals with async stacks.
Comment 5•5 years ago
|
||
Nicolas, maybe you have an idea on how this regressed?
Assignee | ||
Comment 6•5 years ago
|
||
Looking at it right now.
Offender should be Bug 1390768, where we started using SmartTrace, which is based on the debugger Frames component, which does not handle async separator.
I'm looking at a case where the debugger should show such separator, would you have one? or maybe we don't want to show the separator in the call stack panel of the debugger?
Comment 7•5 years ago
|
||
We also want to show async captured stacks in Debugger in bug 1142571, so landing something that adds the separator back for both panels would be great but could be also handled in the other bug as follow up for Debugger.
Assignee | ||
Comment 8•5 years ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d59c3470584a Show async separator in Frame component. r=davidwalsh.
Comment 10•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Hi Janet, it would be great to call this out on the console pages: https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Console_messages
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Verfiied the fix with with 72.0a1 (2019-11-08).
However on, 72.0b4 the returned information appears to still be incomplete.
Is the patch limited to the Nightly branch?
Assignee | ||
Comment 13•5 years ago
|
||
Cristian, it needs javascript.options.asyncstack
pref to be set to true
Comment 14•5 years ago
|
||
Thank you for the info. It does indeed appear, plus some additional evaluations on Windows OS.
Marking the bug as verified based on the previous comment (re-verified with 72.0b4).
Updated•5 years ago
|
Comment 16•5 years ago
|
||
Added section and screenshot about async traces: https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Console_messages#Async_stack_frames
Description
•