Closed
Bug 1593068
Opened 5 years ago
Closed 5 years ago
Remove "text" attribute observing from label now that it's never hosted in XBL anonymous content
Categories
(Toolkit :: XUL Widgets, task)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: bgrins, Assigned: christoph-wa)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
With the Custom Element attribute inheritance we will directly set textContent and we don't need to watch for "text" attribute changes anymore: https://searchfox.org/mozilla-central/rev/ce02064d8afc8673cef83c92896ee873bd35e7ae/toolkit/content/widgets/text.js#69-73.
|
Reporter | |
Comment 1•5 years ago
|
||
It can also be dropped from observedAttributes: https://searchfox.org/mozilla-central/rev/ce02064d8afc8673cef83c92896ee873bd35e7ae/toolkit/content/widgets/text.js#51
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Reporter | |
Updated•5 years ago
|
Assignee: nobody → christoph-wa
Status: NEW → ASSIGNED
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ba47f9818b3
Remove "text" attribute observing from MozTextLabel r=bgrins
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•