Closed
Bug 1593276
Opened 5 years ago
Closed 5 years ago
Add automated test to check if bundle and source files are out of sync for newtab/
Categories
(Firefox :: Messaging System, task, P1)
Firefox
Messaging System
Tracking
()
People
(Reporter: k88hudson, Assigned: emcminn)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
When changing source files like Actions.jsm or scss / jsx in Phabricator, sometimes build assets are not updated, as well as the locale directory.
We should consider adding some kind of automated test that checks for missing changes / inconsistency; one option would be a more coarse-grained approach where if certain files change, the corresponding built file should be changed.
Updated•5 years ago
|
status-firefox72:
--- → affected
Priority: -- → P2
Reporter | ||
Comment 1•5 years ago
|
||
I'd like to prioritize this given a bunch of recent regressions.
Dan suggests:
- simple thing guaranteed to work, but has a lot of latency: add code at the beginning of try-runner.js to look at the date on bundle.js, then look at it after karma has run. if it's change, throw an error to make tree-herder go red
Priority: P2 → P1
Comment 2•5 years ago
|
||
And if we're unhappy with the latency after doing that, we can tighten the feedback loop by fixing some already filed bugs:
- make the builds not use shippable (read PGO) builds by fixing bug 1579162
- then re-land bug 1567929 to run try-runner.js at code-review time
- finally implement bug 1579154 to surface any issues into the front page of the review so it can't be missed
Reporter | ||
Updated•5 years ago
|
Assignee: nobody → emcminn
Iteration: --- → 76.2 - Mar 23 - Apr 5
Reporter | ||
Comment 3•5 years ago
|
||
Dan, can you help take a look at this with Emily?
Updated•5 years ago
|
Iteration: 76.2 - Mar 23 - Apr 5 → 77.1 - Apr 6 - Apr 19
Updated•5 years ago
|
Iteration: 77.1 - Apr 6 - Apr 19 → 77.2 - Apr 20 - May 3
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61c857bfd0fe
Automated test added to try-runner.js to check for changes in activity-stream.bundle r=Mardak
Comment 6•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•