Closed Bug 1593402 Opened 5 years ago Closed 4 years ago

Intermittent toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js | A promise chain failed to handle a rejection: this.transport is null - stack: send@resource://devtools/server/debugger-server-connection.js:89:5

Categories

(Toolkit :: Add-ons Manager, defect, P5)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Project Flags:
Fission Milestone M4.1

People

(Reporter: intermittent-bug-filer, Assigned: ahal)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1593402 - Skip toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js on Linux64/debug with fission, r?#intermittent-reviewers
(deleted), text/x-phabricator-request
Details

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=274154735&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/ZJQwGi33SUSd1aW1xKtZ8g/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/ZJQwGi33SUSd1aW1xKtZ8g/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2019-11-01T20:51:44.772Z] 20:51:44 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js | Should be closing window with correct URI -
[task 2019-11-01T20:51:44.773Z] 20:51:44 INFO - Telling manager window to close
[task 2019-11-01T20:51:44.773Z] 20:51:44 INFO - Manager window close() call returned
[task 2019-11-01T20:51:44.774Z] 20:51:44 INFO - Buffered messages finished
[task 2019-11-01T20:51:44.774Z] 20:51:44 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js | A promise chain failed to handle a rejection: this.transport is null - stack: send@resource://devtools/server/debugger-server-connection.js:89:5
[task 2019-11-01T20:51:44.774Z] 20:51:44 INFO - writeError@resource://devtools/shared/protocol/Actor.js:98:15
[task 2019-11-01T20:51:44.775Z] 20:51:44 INFO - generateRequestHandlers/</handler/</<@resource://devtools/shared/protocol/Actor.js:187:30
[task 2019-11-01T20:51:44.775Z] 20:51:44 INFO - promise callbackgenerateRequestHandlers/</handler/<@resource://devtools/shared/protocol/Actor.js:187:14
[task 2019-11-01T20:51:44.775Z] 20:51:44 INFO - _queueResponse@resource://devtools/shared/protocol/Actor.js:107:28
[task 2019-11-01T20:51:44.776Z] 20:51:44 INFO - handler@resource://devtools/shared/protocol/Actor.js:183:14
[task 2019-11-01T20:51:44.776Z] 20:51:44 INFO - onPacket@resource://devtools/server/debugger-server-connection.js:378:58
[task 2019-11-01T20:51:44.777Z] 20:51:44 INFO - send/<@resource://devtools/shared/transport/local-transport.js:70:25
[task 2019-11-01T20:51:44.777Z] 20:51:44 INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
[task 2019-11-01T20:51:44.777Z] 20:51:44 INFO - DevToolsUtils.executeSoonexports.executeSoon@resource://devtools/shared/DevToolsUtils.js:62:21
[task 2019-11-01T20:51:44.778Z] 20:51:44 INFO - send@resource://devtools/shared/transport/local-transport.js:58:21
[task 2019-11-01T20:51:44.778Z] 20:51:44 INFO - send@resource://devtools/shared/protocol/Front.js:216:30
[task 2019-11-01T20:51:44.779Z] 20:51:44 INFO - request@resource://devtools/shared/protocol/Front.js:234:10
[task 2019-11-01T20:51:44.779Z] 20:51:44 INFO - generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:49:19
[task 2019-11-01T20:51:44.779Z] 20:51:44 INFO - getTarget/this._targetFrontPromise<@resource://devtools/shared/fronts/descriptors/process.js:70:40
[task 2019-11-01T20:51:44.780Z] 20:51:44 INFO - getTarget@resource://devtools/shared/fronts/descriptors/process.js:87:7
[task 2019-11-01T20:51:44.780Z] 20:51:44 INFO - listAllWorkers@resource://devtools/shared/fronts/root.js:107:52
[task 2019-11-01T20:51:44.780Z] 20:51:44 INFO - asynclistWorkers@resource://devtools/client/aboutdebugging/src/modules/client-wrapper.js:157:36
[task 2019-11-01T20:51:44.781Z] 20:51:44 INFO - requestWorkers/<@resource://devtools/client/aboutdebugging/src/actions/debug-targets.js:300:31
[task 2019-11-01T20:51:44.781Z] 20:51:44 INFO - thunk/</<@resource://devtools/client/shared/redux/middleware/thunk.js:15:9
[task 2019-11-01T20:51:44.781Z] 20:51:44 INFO - dispatch@resource://devtools/client/shared/vendor/redux.js:755:18
[task 2019-11-01T20:51:44.782Z] 20:51:44 INFO - onWorkersUpdated@resource://devtools/client/aboutdebugging/src/middleware/debug-target-listener.js:23:11
[task 2019-11-01T20:51:44.782Z] 20:51:44 INFO - emit@resource://devtools/shared/event-emitter.js:190:24
[task 2019-11-01T20:51:44.782Z] 20:51:44 INFO - emit@resource://devtools/shared/event-emitter.js:271:18
[task 2019-11-01T20:51:44.783Z] 20:51:44 INFO - onPacket@resource://devtools/shared/protocol/Front.js:270:13
[task 2019-11-01T20:51:44.783Z] 20:51:44 INFO - onPacket@resource://devtools/shared/client/debugger-client.js:583:13
[task 2019-11-01T20:51:44.784Z] 20:51:44 INFO - send/<@resource://devtools/shared/transport/local-transport.js:70:25
[task 2019-11-01T20:51:44.784Z] 20:51:44 INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
[task 2019-11-01T20:51:44.784Z] 20:51:44 INFO - DevToolsUtils.executeSoonexports.executeSoon@resource://devtools/shared/DevToolsUtils.js:62:21
[task 2019-11-01T20:51:44.785Z] 20:51:44 INFO - send@resource://devtools/shared/transport/local-transport.js:58:21
[task 2019-11-01T20:51:44.785Z] 20:51:44 INFO - send@resource://devtools/server/debugger-server-connection.js:89:20
[task 2019-11-01T20:51:44.785Z] 20:51:44 INFO - onProcessListChanged@resource://devtools/server/actors/root.js:562:15
[task 2019-11-01T20:51:44.786Z] 20:51:44 INFO - observe@resource://devtools/server/actors/process.js:73:12
[task 2019-11-01T20:51:44.786Z] 20:51:44 INFO - Rejection date: Fri Nov 01 2019 20:51:23 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 265
[task 2019-11-01T20:51:44.786Z] 20:51:44 INFO - Stack trace:
[task 2019-11-01T20:51:44.787Z] 20:51:44 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:265
[task 2019-11-01T20:51:44.787Z] 20:51:44 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1100
[task 2019-11-01T20:51:44.788Z] 20:51:44 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-11-01T20:51:44.788Z] 20:51:44 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:926
[task 2019-11-01T20:51:44.788Z] 20:51:44 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-11-01T20:51:44.789Z] 20:51:44 INFO - Leaving test bound testAboutDebugging
[task 2019-11-01T20:51:44.789Z] 20:51:44 INFO - GECKO(9028) | --DOCSHELL 0x7fe5a0479000 == 11 [pid = 9028] [id = {96ffd7a0-52e6-410c-92b2-3257aa77951f}] [url = about:blank]
[task 2019-11-01T20:51:44.790Z] 20:51:44 INFO - GECKO(9028) | JavaScript error: resource://gre/actors/BrowserElementParent.jsm, line 81: TypeError: browser is null
[task 2019-11-01T20:51:44.790Z] 20:51:44 INFO - GECKO(9028) | [Parent 9028, Main Thread] WARNING: 'error.Failed()', file /builds/worker/workspace/build/src/dom/ipc/JSWindowActor.cpp, line 198
[task 2019-11-01T20:51:44.791Z] 20:51:44 INFO - GECKO(9028) | JavaScript error: , line 0: NS_ERROR_UNEXPECTED:
[task 2019-11-01T20:51:44.791Z] 20:51:44 INFO - Console message: [JavaScript Error: "TypeError: browser is null" {file: "resource://gre/actors/BrowserElementParent.jsm" line: 81}]
[task 2019-11-01T20:51:44.792Z] 20:51:44 INFO - Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
[task 2019-11-01T20:51:44.792Z] 20:51:44 INFO - TEST-FAIL | toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js | Assertion count 2 is greater than expected range 0-0 assertions. -

Summary: Intermittent TV toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js | A promise chain failed to handle a rejection: this.transport is null - stack: send@resource://devtools/server/debugger-server-connection.js:89:5 → Intermittent toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js | A promise chain failed to handle a rejection: this.transport is null - stack: send@resource://devtools/server/debugger-server-connection.js:89:5

In bug 1583364 I landed a change that re-arranges which manifests run in which chunks, but it got backed out because it made this issue near perma-fail on Linux64/debug fission. For context, we restart Firefox and clobber the profile between each manifest so theoretically shuffling manifests between chunks shouldn't cause any test isolation issues.

The fact this failure became more frequent suggests that maybe the test is impacted by artifacts on disk but outside the profile somehow. Whatever the cause, bug 1583364 is blocking some important work and we'll need to either:

  1. Fix the test
  2. Tolerate the near perma-fail
  3. Disable the test

Mark it looks like you might own the test, and Kris you wanted to be looped into fission test issues before we take the step of disabling. Would either of you be willing to take a look? Or know someone who is? It might be possible to get an RR trace (use ./mach try --pernosco after applying the patches from https://bugzilla.mozilla.org/show_bug.cgi?id=1583364#c7).

Otherwise I'll have to disable on Linux64 debug with fission (unless the sheriffs agree to tolerate it).
Thanks!

Blocks: 1583364
Flags: needinfo?(mstriemer)
Flags: needinfo?(kmaglione+bmo)

If disabling this test on linux64 debug fission unblocks you then that's fine with me. We shouldn't be blocking any work on this test.

This isn't testing a critical feature, and we've had some pretty consistent issues with our tests that open an about:debugging window. jdescottes proposed some more tweaks we could make to make this test more resilient [1] last time it was updated for intermittents.

[1] https://phabricator.services.mozilla.com/D49015#1487798

Thanks Mark, I'll go ahead and disable it there then.

Andrew, also needinfo'ing you as an fyi (since I'm not sure if Kris is around).

Flags: needinfo?(mstriemer) → needinfo?(continuation)
Assignee: nobody → ahal
Keywords: leave-open

That sounds reasonable to disable it.

Flags: needinfo?(continuation)
Flags: needinfo?(kmaglione+bmo)
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40edee646bc1 Skip toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js on Linux64/debug with fission, r=egao
Assignee: ahal → nobody
Keywords: leave-open

This browser_about_debugging_link.js test is disabled for Fission Linux. We should try re-enabling it.

https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/toolkit/mozapps/extensions/test/browser/browser.ini#47-48

[browser_about_debugging_link.js]
skip-if = os == "linux" && debug && fission # Bug 1593402
Fission Milestone: --- → M4.1

Kashav has a patch in bug 1653674 to try re-enabling this test.

Depends on: 1653674

Got re-enabled in bug 1653674

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → ahal
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: