Closed Bug 1593404 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20056 - [FlexNG] Make items honor indefinite percentage resolution size

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20056 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20056
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[FlexNG] Make items honor indefinite percentage resolution size

We'd already been setting SetIsFixedBlockSizeIndefinite properly, but
children weren't paying attention because we weren't setting their
percentage resolution sizes with CalculateChildPercentageSize.

One more place in FlexNG surely needs this but I haven't yet found a
test case that demonstrates it.

Bug: 845235
Change-Id: I09a6a0414e4fde8ee6cdd146e056c50d718dbc87
Reviewed-on: https://chromium-review.googlesource.com/1895746
WPT-Export-Revision: 923d5a3003777c780223e720a38b6bfe8b8918d1

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 2 tests and 1 subtests

Firefox

OK : 1
PASS: 2

Chrome

OK : 1
PASS: 2

Safari

OK : 1
PASS: 2

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/100072fab9d0 [wpt PR 20056] - [FlexNG] Make items honor indefinite percentage resolution size, a=testonly

https://hg.mozilla.org/mozilla-central/rev/100072fab9d0

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.