Closed Bug 1593438 Opened 5 years ago Closed 5 years ago

Forward- and Back-button no more work in Add-ons Manager

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 72.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

1593438-remove-nav-buttons.patch
(deleted), patch
darktrojan
: review+
Details | Diff | Splinter Review

Very likely because of bug 1525175 the forward and back buttons are no more active when when changing the categories in Add-ons manager.

Also the search field shows "Search addons.mozilla.org" instead of "Search addons.thunderbird.net".

In the console I see:
ReferenceError: reference to undefined property "null" aboutaddons.js:348:3
TypeError: textbox is null aboutAddonsExtra.js:63:23

Geoff, is this something you can fix?

Flags: needinfo?(geoff)

Do we still need those buttons, given the "back to add-ons" link on each page?

I don't see the bug with the search field although I can imagine why others might.

The search field was fixed by bug 1593546.

Do we still need those buttons, given the "back to add-ons" link on each page?

Flags: needinfo?(geoff) → needinfo?(richard.marti)

Haven't noticed this link. Maybe it should be made more prominent.

Yes it seems to me the navigation buttons are no more needed. But we need to look into adding some navigation help in the opened tabs after a extension search or from the "More ways to customize" block.

Flags: needinfo?(richard.marti)

This removes the buttons from Add-ons manager. I hope I've got all correlated JS code.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9106861 - Flags: review?(geoff)
Attached patch 1593438-add-nav-btn-to-content-tabs.patch (obsolete) (deleted) — — Splinter Review

This patch tries to add the navigation buttons to the content tab toolbar to navigate on ATN.

I tried to copy what was done in the Add-ons manager but this doesn't work. The buttons are always disabled. Also maybe the commands don't fit here.

Geoff, please can you help me make this work? As you know I'm not very experienced in such things.

Attachment #9106869 - Flags: feedback?(geoff)
Attachment #9106861 - Flags: review?(geoff) → review+
Comment on attachment 9106869 [details] [diff] [review] 1593438-add-nav-btn-to-content-tabs.patch Review of attachment 9106869 [details] [diff] [review]: ----------------------------------------------------------------- Let's do this in a bug of its own. I think there's a lot more needed to make it work properly.
Attachment #9106869 - Flags: feedback?(geoff)
Attachment #9106869 - Attachment is obsolete: true

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c9940c8a9061
Remove the non-functional navigation buttons in the add-ons manager. r=darktrojan DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: