Closed Bug 1594077 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20090 - Prevent `system-ui` to match `@font-face`

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20090 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20090
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

Prevent system-ui to match @font-face

This patch prevents the system-ui font family name to match
fonts defined by @font-face rules.

Per spec:
https://drafts.csswg.org/css-fonts-4/#family-name-syntax
All generic family names should not match when not quoted.
Supporting it requires more plumbing from the style system
to the font system, and it is not included in this patch.

Bug: 1013882, 1021568
Change-Id: If1aec2254e3aab41bed207a005b4c981d344d7ca

Reviewed-on: https://chromium-review.googlesource.com/1899637
WPT-Export-Revision: d7e4f88b2075c8f25fb34ebb593b74fa6b0f5788

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 1 subtests

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Firefox-only failures

/css/css-fonts/generic-family-keywords-001.html
CSS Test: Test generic family keywords do not match @font-face: Firefox: FAIL

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b4c701ffe9a [wpt PR 20090] - Prevent `system-ui` to match `@font-face`, a=testonly https://hg.mozilla.org/integration/autoland/rev/dfcb5b26ce06 [wpt PR 20090] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2b4c701ffe9a
https://hg.mozilla.org/mozilla-central/rev/dfcb5b26ce06

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.