Closed Bug 1594331 Opened 5 years ago Closed 5 years ago

rewrite Thunderbird consumers of the deprecated "left" and "right" align values to "start" and "end" (port bug 1592369)

Categories

(Thunderbird :: General, task, P1)

Product:
Thunderbird
Component:
General
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 72.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file)

bug1594331_replace_deprecated_align.patch
(deleted), patch
khushil324
: review+
Details | Diff | Splinter Review

From bug 1592369. Need to replace align= values (in xul). left->start, and right->end

Type: defect → task
Attachment #9106868 - Flags: review?(khushil324)
Comment on attachment 9106868 [details] [diff] [review] bug1594331_replace_deprecated_align.patch Review of attachment 9106868 [details] [diff] [review]: ----------------------------------------------------------------- I guess this needs to be taken care: https://dxr.mozilla.org/comm-central/source/comm/editor/ui/composer/content/ComposerCommands.js#2651 All other changes look good. r=khushil
Attachment #9106868 - Flags: review?(khushil324) → review+

What? editor/ui is dead for TB. And you killed it.

Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 72.0

Sorry, ComposerCommands.js file from compose directory. DXR is not showing it.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/724dcab508f5
Port bug 1592369: rewrite consumers of the deprecated "left" and "right" align values to "start" and "end". r=khushil

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

The code in ComposerCommands.js is setting an attribute on html content in the composer. So it doesn't need to be changed (though sure, deprecated in html too.)

Regressions: 1644798
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: