Closed Bug 1594377 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20120 - Add support for the mutable argument to addImportedGlobal.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20120 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20120
Details from upstream follow.

Ms2ger <Ms2ger@gmail.com> wrote:

Add support for the mutable argument to addImportedGlobal.

This also exists in the V8 version at https://cs.chromium.org/chromium/src/v8/test/mjsunit/wasm/wasm-module-builder.js.

I didn't do a complete sync to avoid having to review all the changes.

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 58 tests and 1038 subtests

Firefox

OK : 44
PASS: 1036
FAIL: 2

Chrome

OK : 44
PASS: 1030
FAIL: 8

Safari

OK : 33
PASS : 436
FAIL : 141
ERROR : 11

Firefox-only failures

/wasm/jsapi/module/customSections.any.html
Custom sections with U+FFFD: Firefox: FAIL

/wasm/jsapi/module/customSections.any.worker.html
Custom sections with U+FFFD: Firefox: FAIL

Gecko CI Results

Ran 58 tests and 1038 subtests
OK : 44
PASS : 1036
FAIL : 2

Tests that are disabled

/wasm/jsapi/constructor/compile.any.js
/wasm/jsapi/constructor/instantiate-bad-imports.any.js
/wasm/jsapi/constructor/instantiate.any.js
/wasm/jsapi/constructor/validate.any.js
/wasm/jsapi/instance/constructor-bad-imports.any.js
/wasm/jsapi/instance/constructor.any.js
/wasm/jsapi/instance/exports.any.js
/wasm/jsapi/instance/toString.any.js
/wasm/jsapi/module/constructor.any.js
/wasm/jsapi/module/customSections.any.js
/wasm/jsapi/module/exports.any.js
/wasm/jsapi/module/imports.any.js
/wasm/jsapi/module/toString.any.js
/wasm/jsapi/table/get-set.any.js

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a9cbd014284 [wpt PR 20120] - Add support for the mutable argument to addImportedGlobal., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.