Closed
Bug 1594436
Opened 5 years ago
Closed 5 years ago
Fix glterrain talos test
Categories
(Core :: Graphics: CanvasWebGL, defect, P2)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: mikokm, Assigned: mikokm)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This benchmark does not draw anything because of two WebGL errors:
Error: WebGL warning: uniform1f: Function used is incompatible with uniform of type: <enum 0x8b5e> perftest.html:293:8
Error: WebGL warning: drawElements: Index buffer too small. perftest.html:297:8
Fixing these makes the drawing succeed. The added rasterization cost will most likely cause a talos regression. Local results:
broken
"value": 1.954721185483033
"value": 1.950980062786416
"value": 1.9555333409737576
fixed
"value": 2.0742977111517016
"value": 2.074929356264766
"value": 2.0814426159533617
|
Assignee | |
Updated•5 years ago
|
Summary: Fix glterrain → Fix glterrain talos test
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Priority: -- → P2
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/570e196fe12d
Fix glterrain talos test r=jgilbert
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•