Talos and raptor tests were enabled on ash branch via bug 1539446. Now that we have merged ash to central, can these be enabled on central so we can start Fission measurements on m-c?

I see this comment:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/target_tasks.py#217

That means raptor with Fission enabled is actually not running on Ash at the moment. So we likely can't enable it on trunk (the non-Fission variants are already running there). We could probably turn on Talos though.

But I'm going to redirect this request over to Dave and the perftest team as they have more context around resources and the current state of affairs regarding Talos/Raptor.

Dave (or whoever gets assigned to this), you can enable talos/raptor fission on central using this transform:
https://searchfox.org/mozilla-central/rev/b2b0077c2e6a516a76bf8077d6f0237c58f5959a/taskcluster/taskgraph/transforms/tests.py#1173

We're tracking enabling Fission for Talos and Raptor. I've set those bugs as dependencies here. Stephen: can you give an update on the status? When can we expect to be able to enable Fission for these tests?

(In reply to Dave Hunt [:davehunt] [he/him] ⌚BST from comment #2)

We're tracking enabling Fission for Talos and Raptor. I've set those bugs as dependencies here. Stephen: can you give an update on the status? When can we expect to be able to enable Fission for these tests?

Early next week, I'd expect - Monday or Tuesday, as Marian, who is patch author for both Talos (https://phabricator.services.mozilla.com/D48660) and Raptor (https://phabricator.services.mozilla.com/D48316), returns. There are still some minor tweaks that need to be made, by the looks of it, but it seems in-hand for then.

Enabling Talos is a prerequisite for enabling Fission in Nightly (M6).

Fission M5 so we test sooner

Marian, should this bug be assigned to you so you can close it out once your patches for talos and raptor enablement for Fission lands in central?

Hi Neha,
I'll look into it.
Thanks!

Some updates here:

LANDED:

• the patch for Talos has been created by mconley: https://phabricator.services.mozilla.com/D47809
• i created the patch for AWSY: https://phabricator.services.mozilla.com/D48660
• another patch was required to run the AWSY above : https://phabricator.services.mozilla.com/D53205
• i created another patch that fixed the issue generated by some extra quotes: https://phabricator.services.mozilla.com/D54965

PENDING REVIEW:

• the patch for Raptor fission is almost done, waiting on final review from ahal: https://phabricator.services.mozilla.com/D48316

Then i will use the transform from Andrew's comment https://bugzilla.mozilla.org/show_bug.cgi?id=1594631#c1
to run these tests on central.

Hi Marian,

We are working on adding Fission scenarios in DAMP (DevTools' test suite in talos) in Bug 1454025.
But since DevTools don't support debugging remote frames with Fission enabled yet, I would need to know how we plan to enable fission for talos here.

In this bug, do you plan to enable fission on all Talos tests as tier1 (DAMP included) ?
If yes it means we should keep all our DAMP tests without remote frames for the moment.
We can just use same-site iframes in our Fission-like scenarios until DevTools correctly support Fission.

I get the feeling that in any case, we will want to have Talos running with Fission before DevTools have full support of remote frame debugging.
Thanks!

To minimize resource usage, we can keep talos-with-Fission as a tier3 for now.

(In reply to Julian Descottes [:jdescottes] from comment #9)

Hi Marian,

We are working on adding Fission scenarios in DAMP (DevTools' test suite in talos) in Bug 1454025.
But since DevTools don't support debugging remote frames with Fission enabled yet, I would need to know how we plan to enable fission for talos here.

In this bug, do you plan to enable fission on all Talos tests as tier1 (DAMP included) ?
If yes it means we should keep all our DAMP tests without remote frames for the moment.
We can just use same-site iframes in our Fission-like scenarios until DevTools correctly support Fission.

I get the feeling that in any case, we will want to have Talos running with Fission before DevTools have full support of remote frame debugging.
Thanks!

Hi Julian,
I don't have experience with Talos/DevTools codes and i can't tell at the moment how to enable fission for the DevTools.
The same for "DAMP tests without remote frames" and "same-site iframes" - i have no details/context about these.
The only patch for fission that i know of, that is related to Talos, was created by Mconley - https://phabricator.services.mozilla.com/D47809
It's almost the same logic that i used for Raptor and AWSY. I thought that's all it needs to enable fission for all Talos tests.

As for the transform that Andrew is referring to in comment #1, there i can use conditionals to select only specific tests for fission and exclude Talos until is ready.

Thanks for the feedback, I guess my message was confusing, but my question was: will Talos run with fission enabled as tier1, if so when?

To minimize resource usage, we can keep talos-with-Fission as a tier3 for now.

Thanks! I still think we might want to move that to tier1 before devtools are fully ready to debug remote frames, so I'll just make all the DevTools talos tests use same-site iframes for now.

I have modified the "handle_fission_attributes" transform created by Andrew in this patch:
https://phabricator.services.mozilla.com/D56211

Awsy Fission: ['try', 'trunk', 'mozilla-beta', 'mozilla-release']
Run as "tier: 2" for all platforms except the ones below.
Run as "tier: 3" for:

• linux64/opt
• win64/opt

Talos fission: ['try', 'trunk']

• tier: 2

Raptor fission: ['try', 'trunk']
tier: 2

Please let me know if you want different branches or tiers.
Thanks!

Thanks Marian. We would like to minimize the test runs, so I'd recommend the following:

Suites: awsy-fission, Raptor-fission and Talos-fission
Platforms: linx64-shippable-qr and windows10-64-shippable-qr
Branches: try, mozilla-central

Fission is not yet available on beta or release so those are not needed.

Thanks for the details Neha!

I made new changes, but i don't think that is working as expected, i'll wait for Andrew's review.
https://phabricator.services.mozilla.com/D56411#1728800

I made the changes and run the diff over the files.
All seems to work fine: https://phabricator.services.mozilla.com/D56411#1747635
Thanks, Andrew!

Two examples from the diff over the changes, for linux and windows:

"test-linux64-shippable-qr/opt-raptor-youtube-playback-firefox-fis-e10s": {
"attributes": {
"always_target": false,
"build_platform": "linux64-shippable",
"build_type": "opt",
"e10s": true,
"kind": "test",
"raptor_try_name": "raptor-youtube-playback-firefox-fis",
"retrigger": true,
"run_on_projects": [
"ash",
"mozilla-central",
"try"
],
"shippable": true,
"shipping_phase": null,
"shipping_product": null,
"test_chunk": "1",
"test_manifests": null,
"test_platform": "linux64-shippable-qr/opt",
"unittest_category": "raptor",
"unittest_suite": "raptor",
"unittest_variant": "fission"
},

"test-windows10-64-shippable-qr/opt-raptor-youtube-playback-firefox-fis-e10s": {
"attributes": {
"always_target": false,
"build_platform": "win64-shippable",
"build_type": "opt",
"e10s": true,
"kind": "test",
"raptor_try_name": "raptor-youtube-playback-firefox-fis",
"retrigger": true,
"run_on_projects": [
"ash",
"mozilla-central",
"try"
],
"shippable": true,
"shipping_phase": null,
"shipping_product": null,
"test_chunk": "1",
"test_manifests": null,
"test_platform": "windows10-64-shippable-qr/opt",
"unittest_category": "raptor",
"unittest_suite": "raptor",
"unittest_variant": "fission"
},

Push to try :
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0625003cb7f10c3a373d9af54b0d31b4b897934d

https://hg.mozilla.org/mozilla-central/rev/1fae675369dc