Closed Bug 1594718 Opened 5 years ago Closed 2 years ago

Can't always jump from the console to the inspector in the OBT

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(Fission Milestone:Future)

RESOLVED WORKSFORME
Fission Milestone Future

People

(Reporter: pbro, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-future)

Steps:

  • Have the OBT turned on
  • Open Firefox, with 1 tab opened on a random website
  • Open the OBT and the inspector panel in it
  • With the node picker, go and select a node from the website content area
  • Open the split console and type $0
  • Now select another node in the inspector by clicking in the markup-view, just so your selection is different
  • In the split console, click on the inspector icon next to the node that was logged when you executed $0 previously.

Expected: The node should be selected again.

Actual: it isn't, the selection does not change, and the following JS error is shown: JavaScript error: resource://devtools/shared/fronts/walker.js, line 148: Error: The ValueGrip passed could not be translated to a NodeFront

Blocks: dt-fission

would you mind having a look since you implemented this in OBT? (if you don't have time, I can check myself)

Flags: needinfo?(jlaster)
Summary: Can't always jump from the console to the debugger in the OBT → Can't always jump from the console to the inspector in the OBT
Priority: -- → P3
Whiteboard: dt-fission → dt-fission-reserve

Patrick, do you remember if you had devtools.contenttoolbox.fission turned on?
I could reproduce with the pref set to false, and setting it to true fixed it.

Flags: needinfo?(jlaster) → needinfo?(pbrosset)

I had it set to false.

Flags: needinfo?(pbrosset)

okay, so I guess we can close this bug?

Should this code:
https://searchfox.org/mozilla-central/source/devtools/shared/fronts/inspector.js#158
have a "isBrowserToolboxFission" check in addition to the existing isContentToolboxFission one?

dt-fission-reserve bugs do not need to block Fission Nightly (M6).

Tracking dt-fission-reserve bugs for Fission MVP until we know whether they really need to block Fission or not.

Fission Milestone: --- → MVP

Moving old "dt-fission-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Fission Milestone: MVP → Future
Whiteboard: dt-fission-reserve → dt-fission-future
Severity: normal → S3

I tested comment 0 and this STR works for me using the multiprocess browser toolbox.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.