Distinguish workers in the TargetList
Categories
(DevTools :: Framework, task, P2)
Tracking
(Fission Milestone:M6, firefox78 fixed)
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: ochameau, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In bug 1471754, the original implementation of TargetList, TargetList.TYPES.WORKER could potentially return any type of workers: DEDICATED / SHARED or SERVICE.
This is propably a mistake as SERVICE require some more special treatment and will be hard to support in the current state?
I would suggest to make it so that TargetList.TYPES.WORKER only returns DEDICATED workers, so the regular document workers.
And introduce new types for the other two type of workers:
- TargetList.TYPES.SHARED_WORKER
- TargetList.TYPES.SERVICE_WORKER
Then it would be easier to handle the complex logic that is required for the Service Workers. i.e. this logic: https://searchfox.org/mozilla-central/source/devtools/shared/fronts/root.js#121-187
Reporter | ||
Comment 1•5 years ago
|
||
I imagine it would be easier to first support only TYPES.WORKER and TYPES.SHARED_WORKER in this bug.
And then followup in bug 1594754 to support TYPES.SERVICE_WORKER.
Reporter | ||
Comment 2•5 years ago
|
||
And, it might be great to first start by having tests for regular workers (bug 1594739).
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Comment 6•4 years ago
|
||
bugherder |
Description
•