Closed
Bug 1595471
Opened 5 years ago
Closed 5 years ago
Search/Suggest Parameters for the modern config should be within a code section
Categories
(Firefox :: Search, task, P1)
Firefox
Search
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(3 files)
In attempting more uploads to the staging server for remote settings, I noticed that our current searchUrlGetParams/suggestUrlGetParams (and post) sections are currently not within a code sub-section.
Additionally, the schema is getting some labels wrong, and so we never display an option on the staging UI for setting the get parameters.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D52537
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D52538
|
||
Updated•5 years ago
|
Attachment #9107831 -
Attachment description: Bug 1595471 - Fix issues with search/suggest url parameters being not specified correctly in the schema, and missing a 'codes' wrapper in the config. r?mikedeboer → Bug 1595471 - Fix issues with search/suggest url parameters being not specified correctly in the schema, and missing a 'params' wrapper in the config. r?mikedeboer
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/834ce8215277
Fix issues with search/suggest url parameters being not specified correctly in the schema, and missing a 'params' wrapper in the config. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/1b6f8be366c7
Fix the modern search engine schema regexp to allow all the various locale codes that we currently use. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/fe249d311026
Correct ja-JP-macos references in engines.json for the modern configuration. r=mikedeboer
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/834ce8215277
https://hg.mozilla.org/mozilla-central/rev/1b6f8be366c7
https://hg.mozilla.org/mozilla-central/rev/fe249d311026
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•